mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Duke Xin(辛安文)" <duke_xinanwen@163.com>
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org, jerry.meng@quectel.com,
	duke.xin@quectel.com
Subject: Re: [PATCH] USB: serial: option: add Quectel EM05CN modem
Date: Fri, 13 Jan 2023 08:32:16 +0100	[thread overview]
Message-ID: <Y8EJAN5hf8a8Bj8H@hovoldconsulting.com> (raw)
In-Reply-To: <20230113062739.2970-1-duke_xinanwen@163.com>

On Thu, Jan 12, 2023 at 10:27:39PM -0800, Duke Xin(辛安文) wrote:
> The EM05CN modem has 2 USB configurations that are configurable via the AT
> command AT+QCFG="usbnet",[ 0 | 2 ] which make the modem enumerate with
> the following interfaces, respectively:
> 
> "MBIM"  : AT + MBIM + DIAG + NMEA  + MODEM
> "RMNET" : AT + DIAG + NMEA + Modem + QMI

Thanks for the update. When sending a new revision of patch, make sure
to include a version number in Subject (e.g. in this case "[PATCH v2]
USB: serial: ...).

Also add short changelog below the --- line (so that it doesn't end up
in the git logs).

You again sent two patches with identical Subject adding different
devices. Please add the variant in parenthesis or similar so that we can
tell them apart (e.g. "EM05CN (SG)").

Can you fix that up in a v3 (for both of these patches)?

> Signed-off-by: Duke Xin(辛安文) <duke_xinanwen@163.com>
> ---

Johan

  reply	other threads:[~2023-01-13  7:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13  6:27 Duke Xin(辛安文)
2023-01-13  7:32 ` Johan Hovold [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-01-13  6:45 Duke Xin(辛安文)
2022-12-27  9:01 Duke Xin(辛安文)
2023-01-12 16:31 ` Johan Hovold
2022-12-14  4:35 Duke Xin(辛安文)
2023-01-12 16:19 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8EJAN5hf8a8Bj8H@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=duke.xin@quectel.com \
    --cc=duke_xinanwen@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jerry.meng@quectel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®