From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0284C54EBD for ; Fri, 13 Jan 2023 15:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229928AbjAMPCT (ORCPT ); Fri, 13 Jan 2023 10:02:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjAMPBM (ORCPT ); Fri, 13 Jan 2023 10:01:12 -0500 Received: from mailrelay2-1.pub.mailoutpod2-cph3.one.com (mailrelay2-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:401::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7792463D17 for ; Fri, 13 Jan 2023 06:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=KwQ22b8Nr1nOkVeoMuuOuuiuzvEAnD1GlpwPb7e64as=; b=NnbFIHNQsE4SGlyOpADh5QOibw62s4YIpk8BfSxLHZkosThjDfZasg47Xf95DMgstg4iLLH91bCyA s0tGTA6wMUOCvS5ytmDUTq15usC/vdlh1CBYHZ7zAZDDQN5qt40GbQalL76aWwVxkhA5Ldl7F93HT1 sISdwEfCKZu4YhbeMF76SfoCYSofMnYx4j46O4NqXIu+aZN/dWMKx7WgOAFvVhXoG5y1cQwSlCu8nS AibyXw8+/MSQNMhds2N9oNgNn6mgSiSv/CS8xGWLoEO3qwQPcm76FklvC2cHQu2wejHu9eoIt1kwS7 HubLJxSep0UrRwLYmuStCShFOnvm/3A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-type:mime-version:references:message-id:subject:cc:to: from:date:from; bh=KwQ22b8Nr1nOkVeoMuuOuuiuzvEAnD1GlpwPb7e64as=; b=jXTnJnPbpPvp28lUNFIDX6bN9rE1EJYDsoziEwow3qmbI5T60a0vGRZAw8SefUhP005zyh4s8JP9S MqfcaBdCw== X-HalOne-ID: dac2612b-9351-11ed-80f4-93f0a866dfbb Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay2 (Halon) with ESMTPSA id dac2612b-9351-11ed-80f4-93f0a866dfbb; Fri, 13 Jan 2023 14:52:11 +0000 (UTC) Date: Fri, 13 Jan 2023 15:52:09 +0100 From: Sam Ravnborg To: Stephen Boyd Cc: Thierry Reding , linux-kernel@vger.kernel.org, patches@lists.linux.dev, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, yangcong , Douglas Anderson , Jitao Shi , Rob Clark , Dmitry Baryshkov Subject: Re: [PATCH] drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable Message-ID: References: <20230106030108.2542081-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On Tue, Jan 10, 2023 at 11:29:41AM -0800, Stephen Boyd wrote: > Quoting Sam Ravnborg (2023-01-07 12:28:41) > > > > > For this case we could ask ourself if the display needs to enter sleep > > mode right before we disable the regulator. But if the regulator is > > fixed, so the disable has no effect, this seems OK. > > What do you mean by fixed? What I tried to say here is if we have a fixed regulator - or in others words a supply voltage we cannot turn off, then entering sleep mode is important to reduce power consumption. But any sane design where power consumption is a concern will have the possibility to turn off the power anyway. > > > > > Please fix the unprepare to not jump out early, on top of or together > > with the other fix. > > After this patch the unprepare only bails out early if the bool > 'prepared' flag isn't set. OK, then everything is fine. Sam