From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Charles Keepax <ckeepax@opensource.cirrus.com>,
vkoul@kernel.org, yung-chuan.liao@linux.intel.com,
sanyog.r.kale@intel.com, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction
Date: Fri, 13 Jan 2023 17:11:15 +0000 [thread overview]
Message-ID: <Y8GQs6svuei0SnX6@sirena.org.uk> (raw)
In-Reply-To: <487b7647-8304-8e36-00f2-c9ba3aa50004@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Fri, Jan 13, 2023 at 10:57:39AM -0600, Pierre-Louis Bossart wrote:
> The change from reg_write/read_reg to write/read seems ok, what I was
> asking about was the gather_write.
> + .write = regmap_sdw_write,
> + .gather_write = regmap_sdw_gather_write,
> + .read = regmap_sdw_read,
> what happens if you only have .write and .read? What does the
> .gather_write help with if you only use only address?
Like I said before it means that the core doesn't have to put the
register in a linear buffer with the values, meaning it can avoid
copying already formatted data around or allocating memory.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-01-13 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 17:18 [PATCH 0/2] Minor SoundWire Regmap Tweaks Charles Keepax
2023-01-12 17:18 ` [PATCH 1/2] regmap: sdw: Update misleading comment Charles Keepax
2023-01-12 17:18 ` [PATCH 2/2] regmap: sdw: Remove 8-bit value size restriction Charles Keepax
2023-01-12 17:38 ` Pierre-Louis Bossart
2023-01-12 18:14 ` Mark Brown
2023-01-12 18:43 ` Pierre-Louis Bossart
2023-01-12 19:50 ` Mark Brown
2023-01-12 20:19 ` Pierre-Louis Bossart
2023-01-13 11:02 ` Charles Keepax
2023-01-13 16:57 ` Pierre-Louis Bossart
2023-01-13 17:11 ` Mark Brown [this message]
2023-01-13 18:03 ` Pierre-Louis Bossart
2023-03-10 15:02 ` [PATCH 0/2] Minor SoundWire Regmap Tweaks Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8GQs6svuei0SnX6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®