From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B552DC3DA78 for ; Sat, 14 Jan 2023 14:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbjANOlF (ORCPT ); Sat, 14 Jan 2023 09:41:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbjANOlB (ORCPT ); Sat, 14 Jan 2023 09:41:01 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 617E25242 for ; Sat, 14 Jan 2023 06:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1673707251; bh=KawwwvIcAopLS+CUzfaq6FN0lch5RTPmyrMhaJt02v0=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:MIME-Version: Content-Type; b=DWoGChTmpx8Hi/MvtApluGi9U0dqxY3ffHnPILbm+q1GnR7v92R9rHCICpnryyDkH jFtRNYbEHSmjwqLSxSqBMYRbCbcxydOdpyrDx5uI9lXmLZgk11INjHQWVkZ7zbSkUY MN+pMEspXGbyIB6tifuURqG0eYgOvaBMyQ8oy+Xc= Received: by b-1.in.mailobj.net [192.168.90.11] with ESMTP via ip-206.mailobj.net [213.182.55.206] Sat, 14 Jan 2023 15:40:51 +0100 (CET) X-EA-Auth: cIwL7Ka0hJ+AGbeVlaowRBnhJqla2UVvoZQAoVUfAHAR2tdceZTOQcTouU8Ku1/wcCtCCVf10W/RRSSg8uSEN/NIgoADa2h8 Date: Sat, 14 Jan 2023 20:10:43 +0530 From: Deepak R Varma To: Ben Skeggs , Karol Herbst , Lyude Paul , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Saurabh Singh Sengar , Praveen Kumar Subject: nvkm_devinit_func.disable() to be made void Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, It appears that the callback function disable() of struct nvkm_devinit_func does not need return U64 and can be transformed to be a void. This will impact a few drivers that have currently implementation of this callback since those always return 0ULL. So, Change from 8 struct nvkm_devinit_func { ... ... 15 u64 (*disable)(struct nvkm_devinit *); 1 }; Change to 8 struct nvkm_devinit_func { ... ... 15 void (*disable)(struct nvkm_devinit *); 1 }; I am unsure if this change will have any UAPI impact. Hence wanted to confirm with you if you think this transformation is useful. If yes, I will be happy to submit a patch for your consideration. Please let me know. Thank you, ./drv