From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop OF_GPIO dependency
Date: Mon, 16 Jan 2023 14:00:45 +0200 [thread overview]
Message-ID: <Y8U8bZ9+dOwmDgsb@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MdkgWBb5XTSMEEUQQGCO_3x1a3KK0KbvW4GmAQX1XGbxg@mail.gmail.com>
On Mon, Jan 16, 2023 at 10:03:47AM +0100, Bartosz Golaszewski wrote:
> On Fri, Jan 13, 2023 at 7:25 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
...
> > +#include <linux/mod_devicetable.h>
> > #include <linux/module.h>
> > -#include <linux/gpio/driver.h>
> > +#include <linux/platform_device.h>
> > #include <linux/regmap.h>
> > #include <linux/slab.h>
> > -#include <linux/of_device.h>
> > +
> > +#include <linux/gpio/driver.h>
>
> Any reason for having it separately here?
Yes. The idea is to emphasize the relationship between the driver and
the subsystem it's written for.
P.S. Thanks for applying the rest of my contribution.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-16 12:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 18:26 [PATCH v2 1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells Andy Shevchenko
2023-01-13 18:26 ` [PATCH v2 2/2] gpio: wcd934x: Use proper headers and drop OF_GPIO dependency Andy Shevchenko
2023-01-16 9:03 ` Bartosz Golaszewski
2023-01-16 12:00 ` Andy Shevchenko [this message]
2023-01-16 13:56 ` Bartosz Golaszewski
2023-01-16 14:43 ` Andy Shevchenko
2023-01-16 9:03 ` [PATCH v2 1/2] gpio: wcd934x: Remove duplicate assignment of of_gpio_n_cells Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8U8bZ9+dOwmDgsb@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®