From: Johan Hovold <johan@kernel.org>
To: David Heidelberg <david@ixit.cz>
Cc: clabbe@baylibre.com, gregkh@linuxfoundation.org,
LKML <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 1/2] usb: serial: add support for CH348
Date: Mon, 16 Jan 2023 09:04:27 +0100 [thread overview]
Message-ID: <Y8UFC/1vH/Y9PeBN@hovoldconsulting.com> (raw)
In-Reply-To: <0fa6e2b8-0585-87a3-f255-5301774a6d9d@ixit.cz>
[ Please fix your mailer which generates broken Reply-To headers:
Reply-To: 20230106135338.643951-2-clabbe@baylibre.com
]
On Sat, Jan 14, 2023 at 10:05:18PM +0100, David Heidelberg wrote:
> Acked-by: David Heidelberg <david@ixit.cz>
>
> > + int i;
> > +
> > + for (i = 1; i < CH348_MAXPORT; ++i) {
>
> One nitpick; it would be nice to have a "for" loop from C99+.
No, I prefer this as it stands (and we only have about 80 instances of
such fancy stuff outside of tooling it seems).
Johan
next prev parent reply other threads:[~2023-01-16 8:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 21:05 David Heidelberg
2023-01-16 8:04 ` Johan Hovold [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-06 13:53 [PATCH v5 0/2] " Corentin Labbe
2023-01-06 13:53 ` [PATCH v5 1/2] " Corentin Labbe
2023-02-16 9:14 ` Johan Hovold
2023-02-16 10:29 ` Greg KH
2023-02-16 10:49 ` Johan Hovold
2023-05-21 22:21 ` David Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8UFC/1vH/Y9PeBN@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=clabbe@baylibre.com \
--cc=david@ixit.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®