From: Ashok Raj <ashok.raj@intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>, X86-kernel <x86@kernel.org>,
LKML Mailing List <linux-kernel@vger.kernel.org>,
Tony Luck <tony.luck@intel.com>, Ingo Molnar <mingo@kernel.org>,
<alison.schofield@intel.com>, <reinette.chatre@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Ashok Raj" <ashok.raj@intel.com>
Subject: Re: [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails
Date: Tue, 17 Jan 2023 12:40:30 -0800 [thread overview]
Message-ID: <Y8cHvmU6pa/rNw8n@a4bf019067fa.jf.intel.com> (raw)
In-Reply-To: <Y8brnyIltcgtUvPn@zn.tnic>
On Tue, Jan 17, 2023 at 07:40:31PM +0100, Borislav Petkov wrote:
> On Tue, Jan 17, 2023 at 10:32:50AM -0800, Dave Hansen wrote:
> > Well, we have an awful lot of pr_warn()'s in the kernel that talk about
> > something that was tried and failed.
>
> Well, is microcode loading failure worth to warn about?
Is it not?
>
> What if there's no microcode for that CPU?
If there is no microcode, we don't print anything. So what's loaded in the
CPU is the latest version. When we have something we can always tell if its
successful or not.
Its not a microcode file in initrd, but a matching microcode to load. If
none is found, nothing to worry about.
We just agreed to show both failed and success for late-load. Doing this is
consistent with that isn't it?
https://lore.kernel.org/lkml/Y7iYLbEJSYnVn+dW@zn.tnic/
Ingo's:
https://lore.kernel.org/lkml/Y7k9DNz%2F%2FvqBAvZK@gmail.com/
Should we treat early loading differently?
Cheers,
Ashok
next prev parent reply other threads:[~2023-01-17 22:10 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 15:35 [PATCH v4 0/6] Some fixes and cleanups for microcode Ashok Raj
2023-01-09 15:35 ` [PATCH v4 1/6] x86/microcode: Add a parameter to microcode_check() to store CPU capabilities Ashok Raj
2023-01-21 14:54 ` [tip: x86/microcode] " tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 2/6] x86/microcode/core: Take a snapshot before and after applying microcode Ashok Raj
2023-01-21 14:54 ` [tip: x86/microcode] x86/microcode: Check CPU capabilities after late microcode update correctly tip-bot2 for Ashok Raj
2023-01-09 15:35 ` [PATCH v4 3/6] x86/microcode: Display revisions only when update is successful Ashok Raj
2023-01-09 15:35 ` [PATCH v4 4/6] x86/microcode/intel: Use a plain revision argument for print_ucode_rev() Ashok Raj
2023-01-15 19:25 ` Borislav Petkov
2023-01-15 19:39 ` Borislav Petkov
2023-01-17 16:05 ` Ashok Raj
2023-01-17 18:16 ` Borislav Petkov
2023-01-09 15:35 ` [PATCH v4 5/6] x86/microcode/intel: Print old and new rev during early boot Ashok Raj
2023-01-09 15:35 ` [PATCH v4 6/6] x86/microcode/intel: Print when early microcode loading fails Ashok Raj
2023-01-15 19:05 ` Borislav Petkov
2023-01-17 16:12 ` Ashok Raj
2023-01-17 16:29 ` Dave Hansen
2023-01-17 18:21 ` Borislav Petkov
2023-01-17 18:32 ` Dave Hansen
2023-01-17 18:40 ` Borislav Petkov
2023-01-17 20:40 ` Ashok Raj [this message]
2023-01-17 20:58 ` Luck, Tony
2023-01-19 17:59 ` Ashok Raj
2023-01-20 12:03 ` Borislav Petkov
2023-01-20 16:52 ` Ashok Raj
2023-01-17 21:00 ` Dave Hansen
2023-01-17 21:06 ` Borislav Petkov
2023-01-17 21:34 ` Ashok Raj
2023-01-17 19:10 ` Ashok Raj
2023-01-17 16:35 ` Dave Hansen
2023-01-17 17:59 ` Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8cHvmU6pa/rNw8n@a4bf019067fa.jf.intel.com \
--to=ashok.raj@intel.com \
--cc=alison.schofield@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome