From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD0AC004D4 for ; Wed, 18 Jan 2023 04:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbjAREtO (ORCPT ); Tue, 17 Jan 2023 23:49:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229734AbjAREsv (ORCPT ); Tue, 17 Jan 2023 23:48:51 -0500 Received: from msg-2.mailo.com (msg-2.mailo.com [213.182.54.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE38B4347C for ; Tue, 17 Jan 2023 20:48:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailo.com; s=mailo; t=1674017295; bh=CrkLUeMtrNdwnxo7dSQaVwIRujSfMbGdt5IVuAFQz3k=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=DrUYygIy8N0vpXuxg5PaiBxDOdSmFRoXgm3FAnIuReaTrFLWDpDYq9pAtZHcwLkPR e/rWsAqZ1JT+sLxgQ7bBgx6yu7l36GrfPy1JEEXuHRrxFFYimGFFs508YtEmHzVyYm AaNGoO6EVCVifJK3yz9ZTHy2z1VThMG8BXsANbgI= Received: by b-4.in.mailobj.net [192.168.90.14] with ESMTP via ip-206.mailobj.net [213.182.55.206] Wed, 18 Jan 2023 05:48:15 +0100 (CET) X-EA-Auth: 0H2RaE5We5J7qEl4sTPdiDLLdShReSlIjm3JvD6yCBtdwCoUmnZ1e4mcFnjvlIWsg/cpckZCiDWRzndLuqYvZuXD0zsTIdt6 Date: Wed, 18 Jan 2023 10:18:11 +0530 From: Deepak R Varma To: Rodrigo Vivi Cc: Zhenyu Wang , Saurabh Singh Sengar , dri-devel@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Praveen Kumar , Daniel Vetter , David Airlie Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/gvt: Avoid full proxy f_ops for vgpu_status debug attributes Message-ID: References: <188df08e0feba0cda2c92145f513dd4e57c6e6cf.1673375066.git.drv@mailo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 17, 2023 at 02:29:37PM -0500, Rodrigo Vivi wrote: > On Mon, Jan 16, 2023 at 01:44:46PM +0800, Zhenyu Wang wrote: > > On 2023.01.10 13:49:57 -0500, Rodrigo Vivi wrote: > > > On Wed, Jan 11, 2023 at 12:00:12AM +0530, Deepak R Varma wrote: > > > > Using DEFINE_SIMPLE_ATTRIBUTE macro with the debugfs_create_file() > > > > function adds the overhead of introducing a proxy file operation > > > > functions to wrap the original read/write inside file removal protection > > > > functions. This adds significant overhead in terms of introducing and > > > > managing the proxy factory file operations structure and function > > > > wrapping at runtime. > > > > As a replacement, a combination of DEFINE_DEBUGFS_ATTRIBUTE macro paired > > > > with debugfs_create_file_unsafe() is suggested to be used instead. The > > > > DEFINE_DEBUGFS_ATTRIBUTE utilises debugfs_file_get() and > > > > debugfs_file_put() wrappers to protect the original read and write > > > > function calls for the debug attributes. There is no need for any > > > > runtime proxy file operations to be managed by the debugfs core. > > > > Following coccicheck make command helped identify this change: > > > > > > > > make coccicheck M=drivers/gpu/drm/i915/ MODE=patch COCCI=./scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > > > > > > > Signed-off-by: Deepak R Varma > > > > > > I believe these 2 gvt cases could be done in one patch. > > > But anyways, > > > > > > Reviewed-by: Rodrigo Vivi > > > > > > for both patches... and will leave these 2 patches for gvt folks > > > to apply. Unless they ack and I apply in the drm-intel along with the other ones. > > > > > > > yeah, they're fine with me, feel free to apply them directly. > > > > Acked-by: Zhenyu Wang > > Unfortunately I got some conflicts when trying to apply on drm-intel-next. > > We probably need a new version, and probably through gvt branches it > will be easier to handle conflicts if they appear. Hello Rodrigo, Sure. I will send in a new version. I am current using linux-next git repo as my remote origin [tag 20230113]. Are there any specific instruction/location from where I should access the gvt branch? Thank you. > > > > > thanks! > > > > > > --- > > > > drivers/gpu/drm/i915/gvt/debugfs.c | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/gvt/debugfs.c b/drivers/gpu/drm/i915/gvt/debugfs.c > > > > index 03f081c3d9a4..baccbf1761b7 100644 > > > > --- a/drivers/gpu/drm/i915/gvt/debugfs.c > > > > +++ b/drivers/gpu/drm/i915/gvt/debugfs.c > > > > @@ -165,7 +165,7 @@ static int vgpu_status_get(void *data, u64 *val) > > > > return 0; > > > > } > > > > > > > > -DEFINE_SIMPLE_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); > > > > +DEFINE_DEBUGFS_ATTRIBUTE(vgpu_status_fops, vgpu_status_get, NULL, "0x%llx\n"); > > > > > > > > /** > > > > * intel_gvt_debugfs_add_vgpu - register debugfs entries for a vGPU > > > > @@ -182,8 +182,8 @@ void intel_gvt_debugfs_add_vgpu(struct intel_vgpu *vgpu) > > > > &vgpu_mmio_diff_fops); > > > > debugfs_create_file_unsafe("scan_nonprivbb", 0644, vgpu->debugfs, vgpu, > > > > &vgpu_scan_nonprivbb_fops); > > > > - debugfs_create_file("status", 0644, vgpu->debugfs, vgpu, > > > > - &vgpu_status_fops); > > > > + debugfs_create_file_unsafe("status", 0644, vgpu->debugfs, vgpu, > > > > + &vgpu_status_fops); > > > > } > > > > > > > > /** > > > > -- > > > > 2.34.1 > > > > > > > > > > > > > >