From: Nicolas Schier <nicolas@fjasle.eu>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH v3 2/2] kheaders: use standard naming for the temporary directory
Date: Wed, 18 Jan 2023 08:55:11 +0100 [thread overview]
Message-ID: <Y8el34qPsCq49bKd@bergen.fjasle.eu> (raw)
In-Reply-To: <20230117-kernel-kheaders-gitignore-v3-2-e686b93b0732@weissschuh.net>
[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]
On Wed 18 Jan 2023 05:05:35 GMT, Thomas Weißschuh wrote:
> If the kheaders archive generation is interrupted then this directory
> may be left on disk and not ignored by git.
> By using the standard naming schema for temporary files and directories
> the default .gitignore and "make clean" rules will apply.
>
> Suggested-by: Nicolas Schier <nicolas@fjasle.eu>
> Suggested-by: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> kernel/gen_kheaders.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/gen_kheaders.sh b/kernel/gen_kheaders.sh
> index 473036b43c83..b477b763f262 100755
> --- a/kernel/gen_kheaders.sh
> +++ b/kernel/gen_kheaders.sh
> @@ -7,7 +7,7 @@ set -e
> sfile="$(readlink -f "$0")"
> outdir="$(pwd)"
> tarfile=$1
> -cpio_dir=$outdir/$tarfile.tmp
> +cpio_dir=$outdir/${tarfile%/*}/.tmp_cpio_dir
>
> dir_list="
> include/
>
> --
> 2.39.1
Thanks!
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
Tested-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-18 8:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 5:05 [PATCH v3 0/2] " Thomas Weißschuh
2023-01-18 5:05 ` [PATCH v3 1/2] kbuild: also delete temporary directories Thomas Weißschuh
2023-01-18 7:54 ` Nicolas Schier
2023-01-18 5:05 ` [PATCH v3 2/2] kheaders: use standard naming for the temporary directory Thomas Weißschuh
2023-01-18 7:55 ` Nicolas Schier [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 5:04 [PATCH v3 0/2] " Thomas Weißschuh
2023-01-18 5:04 ` [PATCH v3 2/2] " Thomas Weißschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8el34qPsCq49bKd@bergen.fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®