From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Jacopo Mondi <jacopo@jmondi.org>
Subject: Re: [PATCH] arm64: dts: renesas: r9a09g011: Reword ethernet status
Date: Wed, 18 Jan 2023 17:07:59 +0200 [thread overview]
Message-ID: <Y8gLTxuedrE2TUfq@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230118135259.19249-1-fabrizio.castro.jz@renesas.com>
Hi Fabrizio,
Thank you for the patch.
On Wed, Jan 18, 2023 at 01:52:59PM +0000, Fabrizio Castro wrote:
> Although of_fdt_device_is_available returns true when the DT
> property "status" is assigned "ok" or "okay", and false for every
> other value, it's become common practice to assign "disabled"
> when we want of_fdt_device_is_available to return false.
> For some reason, the status property of the ethernet node was
> assigned "disable" when originally added to the kernel. Change
> it to "disabled" for consistency.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> arch/arm64/boot/dts/renesas/r9a09g011.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> index dd35a8ff72ee..b0c066c5e0ba 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi
> @@ -165,7 +165,7 @@ avb: ethernet@a3300000 {
> power-domains = <&cpg>;
> #address-cells = <1>;
> #size-cells = <0>;
> - status = "disable";
> + status = "disabled";
> };
>
> cpg: clock-controller@a3500000 {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2023-01-18 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 13:52 Fabrizio Castro
2023-01-18 15:07 ` Laurent Pinchart [this message]
2023-01-25 11:08 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8gLTxuedrE2TUfq@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=jacopo@jmondi.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®