mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Li Lingfeng <lilingfeng3@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	axboe@kernel.dk, akpm@linux-foundation.org, jack@suse.cz,
	bingjingc@synology.com, ebiggers@google.com,
	james.smart@broadcom.com, houtao1@huawei.com,
	yi.zhang@huawei.com, yangerkun@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH-next v3] lib: parser: optimize match_NUMER apis to use local array
Date: Thu, 19 Jan 2023 16:00:12 -1000	[thread overview]
Message-ID: <Y8n1rOLdMGDfOgpe@slm.duckdns.org> (raw)
In-Reply-To: <20230120021304.5773-1-lilingfeng3@huawei.com>

On Fri, Jan 20, 2023 at 10:13:04AM +0800, Li Lingfeng wrote:
> Memory will be allocated to store substring_t in match_strdup(), which means
> the caller of match_strdup() may need to be scheduled out to wait for reclaiming
> memory.
> 
> Using local array to store substring_t to remove the restriction.
> 
> Link: https://lore.kernel.org/all/20221104023938.2346986-5-yukuai1@huaweicloud.com/
> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>

 Acked-by: Tejun Heo <tj@kernel.org>

This fixes a sleep-while-atomic splat in blk-iocost, so it'd be a good idea to add:

 Fixes: 2c0647988433 ("blk-iocost: don't release 'ioc->lock' while updating params").

The mm tree likely is the best fit but given the splat the block tree can
work too. Andrew, Jens, what do you think?

Thanks.

-- 
tejun

  reply	other threads:[~2023-01-20  2:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-20  2:13 Li Lingfeng
2023-01-20  2:00 ` Tejun Heo [this message]
2023-01-20  3:50   ` Jens Axboe
2023-01-20  2:07 ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8n1rOLdMGDfOgpe@slm.duckdns.org \
    --to=tj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=bingjingc@synology.com \
    --cc=ebiggers@google.com \
    --cc=houtao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=james.smart@broadcom.com \
    --cc=lilingfeng3@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®