From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 376D7C38142 for ; Fri, 20 Jan 2023 01:34:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbjATBeK (ORCPT ); Thu, 19 Jan 2023 20:34:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbjATBdt (ORCPT ); Thu, 19 Jan 2023 20:33:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD34340BD5; Thu, 19 Jan 2023 17:33:42 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 18F9F514; Fri, 20 Jan 2023 02:33:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674178421; bh=9F69pML5IKaohPNvpEQRBmkT48/bJRXEmHfktbOJy4A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=msIHbk+MIhS+IaAqqpZ6a1qU4JsDPohFBk0wlbUdMWTkXxmq/SRvuiMWpzckDcdzs 0jiXF5qB7rYjOuAq0oLb/OjFxSGUxFdox/JDHjPQ4+oN3qa6sv8ku9i0QzwhS0jLbv n150m5npsM3ogBpr6NJ8WBUcsM6X1RcJgfnScNBo= Date: Fri, 20 Jan 2023 03:33:38 +0200 From: Laurent Pinchart To: Umang Jain Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Wahren , Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , Kieran Bingham , Paul Elder Subject: Re: [PATCH v5 4/6] staging: vc04_services: vchiq-mmal: Drop include Makefile directive Message-ID: References: <20230119115503.268693-1-umang.jain@ideasonboard.com> <20230119115503.268693-5-umang.jain@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230119115503.268693-5-umang.jain@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Umang, Thank you for the patch. On Thu, Jan 19, 2023 at 05:25:01PM +0530, Umang Jain wrote: > Drop the include directive they can break the build one only wants to > build a subdirectory. Replace with "../" for the includes, in the > mmal-vchiq.c instead. > > Suggested-by: Greg Kroah-Hartman > Signed-off-by: Umang Jain > --- > drivers/staging/vc04_services/vchiq-mmal/Makefile | 4 ---- > drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +- > 2 files changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/staging/vc04_services/vchiq-mmal/Makefile b/drivers/staging/vc04_services/vchiq-mmal/Makefile > index c7d3b06e17ce..6937f6534c26 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/Makefile > +++ b/drivers/staging/vc04_services/vchiq-mmal/Makefile > @@ -2,7 +2,3 @@ > bcm2835-mmal-vchiq-objs := mmal-vchiq.o > > obj-$(CONFIG_BCM2835_VCHIQ_MMAL) += bcm2835-mmal-vchiq.o > - > -ccflags-y += \ > - -I$(srctree)/$(src)/.. \ > - -I$(srctree)/$(src)/../include Same comments as for 2/6, although, if we decide to drop 2/6, you could still remove the first of these two -I entries. > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > index 6b5879a33780..234e3764db64 100644 > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c > @@ -23,9 +23,9 @@ > #include > #include > #include > -#include > #include > > +#include "../include/linux/raspberrypi/vchiq.h" > #include "mmal-common.h" > #include "mmal-vchiq.h" > #include "mmal-msg.h" -- Regards, Laurent Pinchart