From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69478C25B50 for ; Fri, 20 Jan 2023 07:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229518AbjATHFf (ORCPT ); Fri, 20 Jan 2023 02:05:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229571AbjATHFc (ORCPT ); Fri, 20 Jan 2023 02:05:32 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFDA760CB1; Thu, 19 Jan 2023 23:05:26 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B19561E2C; Fri, 20 Jan 2023 07:05:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 475CBC433D2; Fri, 20 Jan 2023 07:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674198325; bh=Z7MvmukRBMOVCQZwdpuSlmuG3oETlfTsg97FPGsKsW4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ELxaULdROdpnsoiiTjLMFRuMi2tAln5DRtvohbDMTeLsFWw7tAfEVM+PIdmRbEcDF wr2LmmRjggIz3pf9A47KnGvEU01CbQLdM64WnawYfNEC9qaM07yFzlZisMhAS1501m NrTgWi2wElf9kJw2rry23r53muU4dzGXpqwtM4So= Date: Fri, 20 Jan 2023 08:05:22 +0100 From: Greg Kroah-Hartman To: "Joel Fernandes (Google)" Cc: linux-kernel@vger.kernel.org, Frederic Weisbecker , "Paul E. McKenney" , Zhouyi Zhou , Will Deacon , Marc Zyngier , rcu , Frederic Weisbecker , Ingo Molnar , "Rafael J. Wysocki" , Thomas Gleixner Subject: Re: [PATCH] tick/nohz: Fix cpu_is_hotpluggable() by checking with nohz subsystem Message-ID: References: <20230119204434.4017605-1-joel@joelfernandes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230119204434.4017605-1-joel@joelfernandes.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 19, 2023 at 08:44:35PM +0000, Joel Fernandes (Google) wrote: > For CONFIG_NO_HZ_FULL systems, the tick_do_timer_cpu cannot be offlined. > However, cpu_is_hotpluggable() still returns true for those CPUs. This causes > torture tests that do offlining to end up trying to offline this CPU causing > test failures. Such failure happens on all architectures. > > Fix it by asking the opinion of the nohz subsystem on whether the CPU can > be hotplugged. > > [ Apply Frederic Weisbecker feedback on refactoring tick_nohz_cpu_down(). ] > > Cc: Frederic Weisbecker > Cc: "Paul E. McKenney" > Cc: Zhouyi Zhou > Cc: Will Deacon > Cc: Marc Zyngier > Cc: rcu > Fixes: 2987557f52b9 ("driver-core/cpu: Expose hotpluggability to the rest of the kernel") > Signed-off-by: Joel Fernandes (Google) Also want to cc: stable on the patch? Anyway, for the driver core portion: Acked-by: Greg Kroah-Hartman