From: Eric Biggers <ebiggers@kernel.org>
To: Yangtao Li <frank.li@vivo.com>
Cc: jaegeuk@kernel.org, chao@kernel.org,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v2 1/5] f2fs: fix unnecessary newlines in super.c
Date: Fri, 20 Jan 2023 21:46:49 -0800 [thread overview]
Message-ID: <Y8t8SZ9VGm5fjYAn@sol.localdomain> (raw)
In-Reply-To: <20230121051204.81251-1-frank.li@vivo.com>
On Sat, Jan 21, 2023 at 01:12:00PM +0800, Yangtao Li via Linux-f2fs-devel wrote:
> commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> warning") increased the limit to 100 columns. Let's remove some
> unnecessary newlines.
80 is still the *preferred* limit. See Documentation/process/coding-style.rst:
The preferred limit on the length of a single line is 80 columns.
Statements longer than 80 columns should be broken into sensible chunks,
unless exceeding 80 columns significantly increases readability and does
not hide information.
Also, to avoid churn, patches that just change whitespace generally aren't
accepted, unless they are changing the relevant code anyway.
- Eric
prev parent reply other threads:[~2023-01-21 5:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 5:12 Yangtao Li
2023-01-21 5:12 ` [PATCH v2 2/5] f2fs: fix to set ipu policy Yangtao Li
2023-01-31 2:40 ` Chao Yu
2023-01-21 5:12 ` [PATCH v2 3/5] f2fs: add sanity check for ipu_policy Yangtao Li
2023-01-21 5:12 ` [PATCH v2 4/5] f2fs: introduce ipu_mode sysfs node Yangtao Li
2023-01-21 5:12 ` [PATCH v2 5/5] f2fs: move ipu_policy definitions to uapi header file Yangtao Li
2023-01-21 5:46 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8t8SZ9VGm5fjYAn@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®