From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20337C004D4 for ; Sat, 21 Jan 2023 07:43:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229755AbjAUHnK (ORCPT ); Sat, 21 Jan 2023 02:43:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229450AbjAUHnJ (ORCPT ); Sat, 21 Jan 2023 02:43:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D88647088 for ; Fri, 20 Jan 2023 23:43:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 56F0DB81FA4 for ; Sat, 21 Jan 2023 07:43:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81CDFC433D2; Sat, 21 Jan 2023 07:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674286986; bh=10IGUrE/ednW/QsWBYROUMfdHMqHNh8jURFBLBkOfko=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sM6gvDDoggFQ3HyNatTg2eN3AYicjqFSIhlPrKUyUpB3glX5WQZjLmV8egHFbzn3y PqazScg3AB50bHUC6+5yfp1FA9ci2JzPjsHmszdnid0LGSly1EMdUMHAN3rQZMUZQO 2zG5A34hDHv3BDnF3BkKMVj23GjK1ONvw8KXd9PQ= Date: Sat, 21 Jan 2023 08:43:03 +0100 From: Greg KH To: Phil Auld Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, ritesh.list@gmail.com, srikar@linux.vnet.ibm.com, sshegde@linux.ibm.com, vincent.guittot@linaro.org, vishalc@linux.vnet.ibm.com, vschneid@redhat.com Subject: Re: [PATCH v2] sched/debug: Put sched/domains files under the verbose flag Message-ID: References: <20230119150758.880189-1-pauld@redhat.com> <20230120163330.1334128-1-pauld@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230120163330.1334128-1-pauld@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 20, 2023 at 11:33:30AM -0500, Phil Auld wrote: > The debug files under sched/domains can take a long time to regenerate, > especially when updates are done one at a time. Move these files under > the sched verbose debug flag. Allow changes to verbose to trigger > generation of the files. This lets a user batch the updates but still > have the information available. The detailed topology printk messages > are also under verbose. > > Discussion that lead to this approach can be found in the link below. > > Simplified code to maintain use of debugfs bool routines suggested by > Michael Ellerman . > > Signed-off-by: Phil Auld > Cc: Michael Ellerman > Cc: Greg Kroah-Hartman > Cc: Ingo Molnar > Cc: Peter Zijlstra (Intel) > Cc: Srikar Dronamraju > Cc: Valentin Schneider > Cc: Vishal Chourasia > Cc: Vincent Guittot > Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@li-05afa54c-330e-11b2-a85c-e3f3aa0db1e9.ibm.com/ > --- > > v2: fix comment typo and use cpumask_empty() Acked-by: Greg Kroah-Hartman