From: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
To: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v3] staging: vt6655: Macro with braces issue change to inline function
Date: Sun, 5 Feb 2023 19:11:40 +0100 [thread overview]
Message-ID: <Y9/xXHvOAwfqoDxn@combine-ThinkPad-S1-Yoga> (raw)
This patch is to fix checkpatch warning: "Macro argument 'iobase' may be better
as '(iobase)' to avoid precedence issues" changed to inline function. In
relation to this, names of the callers of macro are also modified to call
this function.
Signed-off-by: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
---
Changes in v3:
- Whitespace error from checkpatch fixed
Changes in v2:
- Macros with one statement that is to call 'iowrite8' function changed
to inline function as reviewed by gregkh@linuxfoundation.org.
In relation to this, names of the callers of macro are also modified
to call this function.
---
drivers/staging/vt6655/card.c | 3 +--
drivers/staging/vt6655/channel.c | 2 +-
drivers/staging/vt6655/mac.h | 4 ++--
3 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/vt6655/card.c b/drivers/staging/vt6655/card.c
index a6ff496b01b6..d2d122dc16d8 100644
--- a/drivers/staging/vt6655/card.c
+++ b/drivers/staging/vt6655/card.c
@@ -643,8 +643,7 @@ void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type)
&byRsvTime);
iowrite16(MAKEWORD(byTxRate, byRsvTime), priv->port_offset + MAC_REG_RSPINF_A_72);
/* Set to Page0 */
- vt6655_mac_select_page0(priv->port_offset);
-
+ vt6655_mac_select_page0(priv->port_offset);
spin_unlock_irqrestore(&priv->lock, flags);
}
diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index e9a44bcebe32..60b445c38424 100644
--- a/drivers/staging/vt6655/channel.c
+++ b/drivers/staging/vt6655/channel.c
@@ -121,7 +121,7 @@ bool set_channel(struct vnt_private *priv, struct ieee80211_channel *ch)
iowrite8(priv->byCurPwr, priv->port_offset + MAC_REG_PWRCCK);
RFbSetPower(priv, RATE_6M, priv->byCurrentCh);
iowrite8(priv->byCurPwr, priv->port_offset + MAC_REG_PWROFDM);
- vt6655_mac_select_page0(priv->port_offset);
+ vt6655_mac_select_page0(priv->port_offset);
spin_unlock_irqrestore(&priv->lock, flags);
}
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index b9a7ca0fe604..ae3064303691 100644
--- a/drivers/staging/vt6655/mac.h
+++ b/drivers/staging/vt6655/mac.h
@@ -539,12 +539,12 @@
static inline void vt6655_mac_select_page0(void __iomem *iobase)
{
- iowrite8(0, iobase + MAC_REG_PAGE1SEL);
+ iowrite8(0, iobase + MAC_REG_PAGE1SEL);
}
static inline void vt6655_mac_select_page1(void __iomem *iobase)
{
- iowrite8(1, iobase + MAC_REG_PAGE1SEL);
+ iowrite8(1, iobase + MAC_REG_PAGE1SEL);
}
#define MAKEWORD(lb, hb) \
--
2.34.1
--
Thanks & Regards,
Guru
next reply other threads:[~2023-02-05 18:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-05 18:11 Guru Mehar Rachaputi [this message]
2023-02-05 19:12 ` Christophe JAILLET
2023-02-05 23:39 ` Guru Mehar Rachaputi
2023-02-06 9:43 ` Greg Kroah-Hartman
2023-02-07 7:25 ` Guru Mehar Rachaputi
2023-02-07 7:39 ` Greg Kroah-Hartman
2023-02-07 8:52 ` Guru Mehar Rachaputi
2023-02-07 8:19 ` Deepak R Varma
2023-02-07 8:49 ` Guru Mehar Rachaputi
2023-02-07 9:47 ` Deepak R Varma
2023-03-06 4:52 ` Guru Mehar Rachaputi
2023-03-06 5:36 ` Deepak R Varma
2023-03-06 5:57 ` Guru Mehar Rachaputi
2023-03-06 7:00 ` Deepak R Varma
2023-03-06 7:48 ` Guru Mehar Rachaputi
2023-03-06 8:31 ` Deepak R Varma
2023-03-08 17:23 ` Guru Mehar Rachaputi
-- strict thread matches above, loose matches on Subject: below --
2023-02-05 13:08 Guru Mehar Rachaputi
2023-02-05 13:16 ` Greg Kroah-Hartman
2023-02-05 13:30 ` Guru Mehar Rachaputi
2023-02-05 15:34 ` Nam Cao
2023-02-05 18:13 ` Guru Mehar Rachaputi
2023-02-05 18:21 ` Guru Mehar Rachaputi
2023-02-05 13:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9/xXHvOAwfqoDxn@combine-ThinkPad-S1-Yoga \
--to=gurumeharrachaputi@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®