mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Gushchin <roman.gushchin@linux.dev>
To: Sukadev Bhattiprolu <quic_sukadev@quicinc.com>
Cc: Chris Goldsworthy <quic_cgoldswo@quicinc.com>,
	Rik van Riel <riel@surriel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Roman Gushchin <guro@fb.com>, Vlastimil Babka <vbabka@suse.cz>,
	Joonsoo Kim <js1304@gmail.com>, Minchan Kim <minchan@kernel.org>,
	Georgi Djakov <quic_c_gdjako@quicinc.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,page_alloc,cma: configurable CMA utilization
Date: Fri, 3 Feb 2023 16:04:54 -0800	[thread overview]
Message-ID: <Y92hJjFfIuQufkGT@P9FQF9L96D.corp.robot.car> (raw)
In-Reply-To: <20230202201302.GB22373@hu-sbhattip-lv.qualcomm.com>

On Thu, Feb 02, 2023 at 12:13:02PM -0800, Sukadev Bhattiprolu wrote:
> 
> Hi Roman,
> 
> On Wed, Feb 01, 2023 at 11:00:25AM -0800, Roman Gushchin wrote:
> > Then _maybe_ a new knob is justified, at least I don't have better ideas.
> > Rik, do you have any input here?
> > 
> > Let's then define it in a more generic way and _maybe_ move to the cma
> > sysfs/debugfs (not 100% sure about this part, but probably worth exploring).
> 
> We should be able to use a sysfs parameter too. Will try that out.

Thanks. The reason I think it might be preferable is that new sysctls are hated
by everyone and this use case looks a very niche.

> But could you elaborate on what is more generic way?

I mean in the proposed patch it's only possible to shift the ratio towards cma:
a larger sysctl value will make allocations from the cma area happening earlier.
The value 1 will turn it off completely.

Probably better to define the new knob in % or 1/1000's with the default value
50% or 500. 0 will mean never use cma from this path, 999 - always.
Something along these lines.

Thanks!

  reply	other threads:[~2023-02-04  0:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-31  7:10 Sukadev Bhattiprolu
2023-01-31  7:23 ` Anshuman Khandual
2023-01-31 14:26 ` Georgi Djakov
2023-01-31 18:10 ` Roman Gushchin
2023-01-31 20:10   ` Sukadev Bhattiprolu
2023-01-31 23:59     ` Roman Gushchin
2023-02-01  4:06       ` Chris Goldsworthy
2023-02-01 19:00         ` Roman Gushchin
2023-02-02 20:13           ` Sukadev Bhattiprolu
2023-02-04  0:04             ` Roman Gushchin [this message]
2023-02-01 23:47         ` Minchan Kim
2023-02-06  5:22           ` Chris Goldsworthy
2023-02-08 22:00             ` Minchan Kim
2024-01-05 23:46           ` Sukadev Bhattiprolu
2024-01-06  0:05             ` Roman Gushchin
2024-01-08 20:15               ` Sukadev Bhattiprolu
2024-01-09  2:59                 ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y92hJjFfIuQufkGT@P9FQF9L96D.corp.robot.car \
    --to=roman.gushchin@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=guro@fb.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=quic_c_gdjako@quicinc.com \
    --cc=quic_cgoldswo@quicinc.com \
    --cc=quic_sukadev@quicinc.com \
    --cc=riel@surriel.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®