From: Guru Mehar Rachaputi <gurumeharrachaputi@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: Regarding checkpatch camelcase issues
Date: Sun, 5 Feb 2023 00:46:25 +0100 [thread overview]
Message-ID: <Y97uUeB6OfO469SY@combine-ThinkPad-S1-Yoga> (raw)
In-Reply-To: <Y94L+WNGGfvrg6Mg@debian.me>
On Sat, Feb 04, 2023 at 02:40:41PM +0700, Bagas Sanjaya wrote:
> On Sat, Feb 04, 2023 at 05:25:38AM +0100, Guru Mehar Rachaputi wrote:
> > Thanks for your support.
> >
> > I wanted to confirm if each checkpatch encounter for camelcase issue should
> > be fixed in a new patch?
> >
> > For example: If the issue is with same variable, then multiple
> > modifications can be made in one patch.
> >
> > -> above example is OK
> >
> >
> > For example: If the issue is with multiple variables, then multiple
> > modifications can be made in one patch.
> >
> > -> above example is NOT OK / NG
> >
> >
> > Please confirm me if my understanding is correct?
> >
>
> I guess you have generated a patch series, then check it through
> checkpatch.
>
> Indeed, if checkpatch complains at a particular patch, you need to do
> interactive rebase. Make sure that rebase todo list contains "edit"
> lines on commit you want to fix up. After that, fix these complaints.
>
> When you're done, regenerate the patch series and make sure that there
> are no checkpatch complains on it.
>
> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara
Thanks for the reply
I guess I was not clear. When I run checkpatch on a driver there
were so many camelcase issues in each file. So I wanted to know if I
proceed to fix them, should I submit each change as a patch or each file
as a patch?
Since each file has many camelcase issue and the driver has morethan one
such file.
--
Thanks & Regards,
Guru
next prev parent reply other threads:[~2023-02-04 23:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-04 4:25 Guru Mehar Rachaputi
2023-02-04 7:40 ` Bagas Sanjaya
2023-02-04 23:46 ` Guru Mehar Rachaputi [this message]
2023-02-05 4:27 ` Deepak R Varma
2023-02-05 13:13 ` Guru Mehar Rachaputi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y97uUeB6OfO469SY@combine-ThinkPad-S1-Yoga \
--to=gurumeharrachaputi@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®