mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: MAX3421: Handle USB NAK correctly
Date: Fri, 27 Jan 2023 07:22:52 +0100	[thread overview]
Message-ID: <Y9NtvKbY1nfoVtw9@kroah.com> (raw)
In-Reply-To: <20230127024734.8777-1-mark.tomlinson@alliedtelesis.co.nz>

On Fri, Jan 27, 2023 at 03:47:34PM +1300, Mark Tomlinson wrote:
> A USB peripheral can respond with a NAK if it is not yet ready to
> send/receive data. In this case, the transaction should be retried. The
> MAX3421 driver did do this, and switched to a different type of retry
> after a number of 'fast' retries. On at least some USB flash devices,
> this second type of retry never succeeds. This patch changes the
> behaviour so that 'fast' retries continue.
> 
> Signed-off-by: Mark Tomlinson <mark.tomlinson@alliedtelesis.co.nz>
> ---
>  drivers/usb/host/max3421-hcd.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)

What commit id does this fix?  And should it be backported to older
kernel trees?

thanks,

greg k-h

  reply	other threads:[~2023-01-27  6:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27  2:47 Mark Tomlinson
2023-01-27  6:22 ` Greg KH [this message]
2023-01-29 22:05   ` Mark Tomlinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9NtvKbY1nfoVtw9@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.tomlinson@alliedtelesis.co.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®