mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Angel Iglesias <ang.iglesiasg@gmail.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andreas Klinger <ak@it-klinger.de>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/7] Add support for pressure sensor Bosch BMP580
Date: Mon, 30 Jan 2023 14:30:18 +0200	[thread overview]
Message-ID: <Y9e4WviD+Lmiin9T@smile.fi.intel.com> (raw)
In-Reply-To: <cover.1674954271.git.ang.iglesiasg@gmail.com>

On Sun, Jan 29, 2023 at 02:33:02AM +0100, Angel Iglesias wrote:
> This patchset adds support for the new pressure sensors BMP580 extending
> the bmp280 driver.
> 
> Patch 1 introduces a minor refactor of the driver structure to change how
> the device matching and driver initialization is performed. In place of
> the chips ids, the driver_data now contains a pointer to its chip_info.
> To perform this change, a series of declarations previously on the core
> file were migrated to the shared header file, to allow access to specific
> fields on the chip_info on the I2C and SPI drivers. This change is
> required because BMP380 and BMP580 have the same chip_id and values would
> collide using the chip_id as the driver_data value.
> Patch 2 introduces new preinit callback and unifies init logic across all
> supported variants.
> Patch 3 made calibration callback function optional.
> Patch 4 deletes misleading i2c reference on bmp280 Kconfig entry.
> Patch 5 extends the bmp280 driver with the new logic to read measurements
> and configure the operation parameters for the BMP580 sensors.
> Patch 6 updates the devicetree binding docs with the new sensor id.
> Patch 7 adds the NVMEM operations to read and program the NVM user range
> contained in the non-volatile memory of the BMP580 sensors.

Patches 1-5 are good enough for me,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

If anything, we can fix in the followups.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2023-01-30 12:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-29  1:33 Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 1/7] iio: pressure: bmp280: Use chip_info pointers for each chip as driver data Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 2/7] iio: pressure: bmp280: Add preinit callback Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 3/7] iio: pressure: bmp280: Make read calibration callback optional Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 4/7] iio: pressure: Kconfig: Delete misleading I2C reference on bmp280 title Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 5/7] iio: pressure: bmp280: Add support for new sensor BMP580 Angel Iglesias
2023-02-05 14:53   ` Jonathan Cameron
2023-02-05 23:39     ` Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 6/7] dt-bindings: iio: pressure: bmp085: Add BMP580 compatible string Angel Iglesias
2023-01-29  1:33 ` [PATCH v3 7/7] iio: pressure: bmp280: Add nvmem operations for BMP580 Angel Iglesias
2023-01-30 12:29   ` Andy Shevchenko
2023-01-31 22:36     ` Angel Iglesias
2023-01-30 12:30 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9e4WviD+Lmiin9T@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=ak@it-klinger.de \
    --cc=ang.iglesiasg@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome