From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B07C54EED for ; Mon, 30 Jan 2023 11:32:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235716AbjA3Lci (ORCPT ); Mon, 30 Jan 2023 06:32:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236641AbjA3Lc3 (ORCPT ); Mon, 30 Jan 2023 06:32:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 196373346A; Mon, 30 Jan 2023 03:32:29 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C3E72B80F9F; Mon, 30 Jan 2023 11:32:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 00B96C433D2; Mon, 30 Jan 2023 11:32:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1675078346; bh=6XI6zgRYqIg/bSErmwXqT/Itie5Q/+BahKbvCx4Lfnk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kj7K/X7zUsazsx7bq3reSvtouS+BNiIaBE6hZQ8+J63BCn1pf6aCTUlQ45JAR2CjK JX3epKmZnnYPAAL2LcxOBVEB485sJfux0JsOGGqZbsf+8LMjce585BktNy0w33NQ1z gYUczvy48oIiZ2JkljjnNpxDDnfmm7HPPWpBLA98= Date: Mon, 30 Jan 2023 12:32:23 +0100 From: Greg KH To: nick black Cc: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net-sysfs: add rx_otherhost_dropped stat entry Message-ID: References: <20230130112919.273446-1-dankamongmen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130112919.273446-1-dankamongmen@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2023 at 06:29:20AM -0500, nick black wrote: > Add the sysfs export for rx_otherhost_dropped, added > in 794c24e9921f32ded4422833a990ccf11dc3c00e > ("rx_otherhost_dropped to core_stats"). Please read the kernel documentation for how to properly refer to a commit in the tree. But more importantly, this changelog does not describe why this is needed, or even what this is doing at all. And if it's a sysfs file you are adding, where is the Documentation/ABI/ entry? Also, why me? I'm not the maintainer of this file :) thanks, greg k-h