From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Arun.Ramadoss@microchip.com
Subject: Re: [PATCH net-next v3 02/15] net: phy: add genphy_c45_read_eee_abilities() function
Date: Mon, 30 Jan 2023 22:55:12 +0100 [thread overview]
Message-ID: <Y9g8wOED58xKwu4m@lunn.ch> (raw)
In-Reply-To: <20230130080714.139492-3-o.rempel@pengutronix.de>
> +static inline void mii_eee_100_10000_adv_mod_linkmode_t(unsigned long *adv,
> + u32 val)
> +{
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT,
> + adv, val & MDIO_EEE_100TX);
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseT_Full_BIT,
> + adv, val & MDIO_EEE_1000T);
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_10000baseT_Full_BIT,
> + adv, val & MDIO_EEE_10GT);
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_1000baseKX_Full_BIT,
> + adv, val & MDIO_EEE_1000KX);
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT,
> + adv, val & MDIO_EEE_10GKX4);
> + linkmode_mod_bit(ETHTOOL_LINK_MODE_10000baseKR_Full_BIT,
> + adv, val & MDIO_EEE_10GKR);
> +}
This and mmd_eee_cap_to_ethtool_sup_t() are very similar. Could you
try to remove the duplication. Maybe
ethtool_convert_link_mode_to_legacy_u32() could be used?
Andrew
next prev parent reply other threads:[~2023-01-30 21:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 8:06 [PATCH net-next v3 00/15] net: add EEE support for KSZ9477 and AR8035 with i.MX6 Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 01/15] net: dsa: microchip: enable EEE support Oleksij Rempel
2023-01-30 17:59 ` Vladimir Oltean
2023-01-30 8:07 ` [PATCH net-next v3 02/15] net: phy: add genphy_c45_read_eee_abilities() function Oleksij Rempel
2023-01-30 21:55 ` Andrew Lunn [this message]
2023-01-30 8:07 ` [PATCH net-next v3 03/15] net: phy: micrel: add ksz9477_get_features() Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 04/15] net: phy: export phy_check_valid() function Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 05/15] net: phy: add genphy_c45_ethtool_get/set_eee() support Oleksij Rempel
2023-01-30 22:06 ` Andrew Lunn
2023-01-30 8:07 ` [PATCH net-next v3 06/15] net: phy: c22: migrate to genphy_c45_write_eee_adv() Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 07/15] net: phy: c45: " Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 08/15] net: phy: start using genphy_c45_ethtool_get/set_eee() Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 09/15] net: phy: add driver specific get/set_eee support Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 10/15] net: phy: at803x: implement ethtool access to SmartEEE functionality Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 11/15] net: phy: at803x: ar8035: fix EEE support for half duplex links Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 12/15] net: phy: add PHY specifica flag to signal SmartEEE support Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 13/15] net: phy: at803x: add PHY_SMART_EEE flag to AR8035 Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 14/15] net: phy: add phy_has_smarteee() helper Oleksij Rempel
2023-01-30 8:07 ` [PATCH net-next v3 15/15] net: fec: add support for PHYs with SmartEEE support Oleksij Rempel
2023-01-31 20:52 ` Vladimir Oltean
2023-02-01 12:45 ` Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9g8wOED58xKwu4m@lunn.ch \
--to=andrew@lunn.ch \
--cc=Arun.Ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®