mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Matthias Kaehlcke <mka@chromium.org>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Mathias Nyman <mathias.nyman@intel.com>,
	"open list:USB XHCI DRIVER" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH stable 5.4] usb: host: xhci-plat: add wakeup entry at sysfs
Date: Fri, 3 Feb 2023 08:58:57 +0100	[thread overview]
Message-ID: <Y9y+wRPYzQVwb3JS@kroah.com> (raw)
In-Reply-To: <319ebea0-61dc-2e08-f48b-4555b8fb894a@gmail.com>

On Wed, Feb 01, 2023 at 03:19:08PM -0800, Florian Fainelli wrote:
> On 2/1/23 10:16, Greg Kroah-Hartman wrote:
> > On Wed, Feb 01, 2023 at 09:44:04AM -0800, Florian Fainelli wrote:
> > > From: Peter Chen <peter.chen@nxp.com>
> > > 
> > > commit  4bb4fc0dbfa23acab9b762949b91ffd52106fe4b upstream
> > > 
> > > With this change, there will be a wakeup entry at /sys/../power/wakeup,
> > > and the user could use this entry to choose whether enable xhci wakeup
> > > features (wake up system from suspend) or not.
> > > 
> > > Tested-by: Matthias Kaehlcke <mka@chromium.org>
> > > Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
> > > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > > Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > > Link: https://lore.kernel.org/r/20200918131752.16488-6-mathias.nyman@linux.intel.com
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > > ---
> > >   drivers/usb/host/xhci-plat.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Why is this new feature needed on these older kernels?  What does it fix
> > that is broken?
> 
> It fixes the inability to make the XHCI controller a wake-up device since
> there is no /sys/*/*xhci/power/wakeup sysfs entry to manipulate unless this
> patch is applied.

But that is a new feature, not a bugfix.

What systems need this for these older kernels that will actually update
to them in order to pick up this change?

thanks,

greg k-h

  reply	other threads:[~2023-02-03  7:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-01 17:44 [PATCH stable 4.14] " Florian Fainelli
2023-02-01 17:44 ` [PATCH stable 4.19] " Florian Fainelli
2023-02-01 17:44 ` [PATCH stable 5.4] " Florian Fainelli
2023-02-01 18:16   ` Greg Kroah-Hartman
2023-02-01 23:19     ` Florian Fainelli
2023-02-03  7:58       ` Greg Kroah-Hartman [this message]
2023-02-03 17:50         ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9y+wRPYzQVwb3JS@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=mka@chromium.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome