From: Herbert Xu <herbert@gondor.apana.org.au>
To: Peter Lafreniere <peter@n8pjl.ca>
Cc: linux-crypto@vger.kernel.org, peter@n8pjl.ca, ardb@kernel.org,
linux-kernel@vger.kernel.org, conor.dooley@microchip.com,
x86@kernel.org
Subject: Re: [PATCH RESEND] crypto: x86 - exit fpu context earlier in ECB/CBC macros
Date: Fri, 3 Feb 2023 13:03:10 +0800 [thread overview]
Message-ID: <Y9yVjerSZcAkkmDf@gondor.apana.org.au> (raw)
In-Reply-To: <20230121183450.14570-1-peter@n8pjl.ca>
Peter Lafreniere <peter@n8pjl.ca> wrote:
> Currently the ecb/cbc macros hold fpu context unnecessarily when using
> scalar cipher routines (e.g. when handling odd sizes of blocks per walk).
>
> Change the macros to drop fpu context as soon as the fpu is out of use.
>
> No performance impact found (on Intel Haswell).
>
> Signed-off-by: Peter Lafreniere <peter@n8pjl.ca>
> ---
> arch/x86/crypto/ecb_cbc_helpers.h | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2023-02-03 5:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 18:34 Peter Lafreniere
2023-01-31 8:30 ` Ard Biesheuvel
2023-02-03 5:03 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9yVjerSZcAkkmDf@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=ardb@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@n8pjl.ca \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®