From: Vinod Koul <vkoul@kernel.org>
To: Neill Kapron <nkapron@google.com>
Cc: Kishon Vijay Abraham I <kishon@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Chris Zhong <zyw@rock-chips.com>,
Kever Yang <kever.yang@rock-chips.com>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, kernel-team@android.com,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH] phy: rockchip-typec: fix tcphy_get_mode error case
Date: Fri, 3 Feb 2023 17:13:48 +0530 [thread overview]
Message-ID: <Y9zzdBZiQx460D/z@matsya> (raw)
In-Reply-To: <20230126001013.3707873-1-nkapron@google.com>
On 26-01-23, 00:10, Neill Kapron wrote:
> The existing logic in tcphy_get_mode() can cause the phy to be
> incorrectly configured to USB UFP or DisplayPort mode when
> extcon_get_state returns an error code.
>
> extcon_get_state() can return 0, 1, or a negative error code.
>
> It is possible to get into the failing state with an extcon driver
> which does not support the extcon connector id specified as the
> second argument to extcon_get_state().
>
> tcphy_get_mode()
> ->extcon_get_state()
> -->find_cable_index_by_id()
> --->return -EINVAL;
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2023-02-03 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:10 Neill Kapron
2023-01-26 16:41 ` Lee Jones
2023-02-03 11:43 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9zzdBZiQx460D/z@matsya \
--to=vkoul@kernel.org \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=kernel-team@android.com \
--cc=kever.yang@rock-chips.com \
--cc=kishon@kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nkapron@google.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome