From: Peter Zijlstra <peterz@infradead.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
Ingo Molnar <mingo@redhat.com>,
will@kernel.org, mark.rutland@arm.com, mike.leach@linaro.org,
al.grant@arm.com, anshuman.khandual@arm.com,
mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org,
jolsa@redhat.com, acme@kernel.org
Subject: Re: [RFC PATCH] perf: Handle multiple formatted AUX records
Date: Mon, 25 Jan 2021 12:01:56 +0100 [thread overview]
Message-ID: <YA6lJPG7DGnlL8yh@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <b30069fb-3df4-8c8a-9ee8-471c0a6d5f38@arm.com>
On Mon, Jan 25, 2021 at 10:45:06AM +0000, Suzuki K Poulose wrote:
> On 1/25/21 10:25 AM, Peter Zijlstra wrote:
> > Since we have a whole u64, do we want to reserve a whole nibble (or
> > maybe even a byte) for a format type? Because with a single bit like
> > this, we'll kick ourselves when we end up with the need for a 3rd format
> > type.
> >
>
> Sure, makes sense. We could do:
>
> #define PERF_AUX_FLAG_PMU_FORMAT_TYPE_MASK 0xff00
>
> Additionally, the values could be allocated by individual PMUs and
> interpreted by the corresponding counterpart. That way we don't
> have to worry about centralized allocation of the "TYPE" fields.
>
> e,g:
>
> #define PERF_AUX_FLAG_CORESIGHT_FORMAT_CORESIGHT 0x0000
> #define PERF_AUX_FLAG_CORESIGHT_FORMAT_RAW 0x0100
>
> #define PERF_AUX_FLAG_RANDOM_PMU_FORMAT_FMT1 0x0000
> #define PERF_AUX_FLAG_RANDOM_PMU_FORMAT_FMT2 0x0100
>
>
> What do you think ?
Sounds good to me.
prev parent reply other threads:[~2021-01-25 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 15:18 [RFC PATCH 0/1] " Suzuki K Poulose
2021-01-22 15:18 ` [RFC PATCH] " Suzuki K Poulose
2021-01-25 10:25 ` Peter Zijlstra
2021-01-25 10:45 ` Suzuki K Poulose
2021-01-25 11:01 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YA6lJPG7DGnlL8yh@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=al.grant@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®