From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54C76C433E0 for ; Tue, 26 Jan 2021 02:51:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CBF222E03 for ; Tue, 26 Jan 2021 02:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729422AbhAYOXt (ORCPT ); Mon, 25 Jan 2021 09:23:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729359AbhAYOSY (ORCPT ); Mon, 25 Jan 2021 09:18:24 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3677C061574 for ; Mon, 25 Jan 2021 06:17:43 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4346B331; Mon, 25 Jan 2021 15:15:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1611584136; bh=JgPs6f9hCrtjm0ZgJDLYxgtV0kXtWZhAud13sZqCi2A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pqb5FGh8FGVpVjLFjpk4dWBxemBh5bJCk54xcoBvEraHt8d0Njr5IO/lhSI0VdvDx Wk/aNdS0hML5zQ+PTWbje3UFK2jPF5FuWZdo4TOFatWtP0iEbQqSWpYW0DNB3bivv1 UJx2w8fd91ZsOaHB3hUu2zyRRQHjX9LAkHhNVYA4= Date: Mon, 25 Jan 2021 16:15:17 +0200 From: Laurent Pinchart To: Helen Koike Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl, hans.verkuil@cisco.com, kernel@collabora.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] media: doc: pixfmt-yuv: Fix 4:4:4 subsampling info Message-ID: References: <20210125141029.16481-1-helen.koike@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210125141029.16481-1-helen.koike@collabora.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Helen, Thank you for the patch. On Mon, Jan 25, 2021 at 11:10:29AM -0300, Helen Koike wrote: > YUV 4:4:4 is not subsampled, fix this in the docs. > > Fixes: da785536e007 ("media: doc: pixfmt-yuv: Move all semi-planar YUV formats to common file") > Signed-off-by: Helen Koike Reviewed-by: Laurent Pinchart > --- > Changes in v2: > > - s/No sub-sampling/The chroma plane is not subsampled/ (Laurent) > - Fixed description regarding the number of bytes (Laurent) > --- > Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst > index 7d4d39201a3f..1e0db602cc1b 100644 > --- a/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst > +++ b/Documentation/userspace-api/media/v4l/pixfmt-yuv-planar.rst > @@ -396,9 +396,9 @@ number of lines as the luma plane. > NV24 and NV42 > ------------- > > -Semi-planar YUV 4:4:4 formats. The chroma plane is subsampled by 2 in the > -horizontal direction. Chroma lines contain half the number of pixels and the > -same number of bytes as luma lines, and the chroma plane contains the same > +Semi-planar YUV 4:4:4 formats. The chroma plane is not subsampled. > +Chroma lines contain the same number of pixels and twice the > +number of bytes as luma lines, and the chroma plane contains the same > number of lines as the luma plane. > > .. flat-table:: Sample 4x4 NV24 Image -- Regards, Laurent Pinchart