From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B164C433DB for ; Wed, 20 Jan 2021 17:18:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3768A233E2 for ; Wed, 20 Jan 2021 17:18:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403791AbhATRSq (ORCPT ); Wed, 20 Jan 2021 12:18:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:32932 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404050AbhATRSS (ORCPT ); Wed, 20 Jan 2021 12:18:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 07C7022CE3; Wed, 20 Jan 2021 17:17:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1611163058; bh=9WZ/m19z2HGkINVwNeYp/+wcK7hXnj4kx5NeS4ydpJU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XAosQ5P65dgOHKIO0YQi5Sj0fPMVYX1loaU/SHZ1bBzto/EbQxH7ttoCeQld4jojx 6/YFWJLma/2eAPw1Aq2WhdJ/koSKXt+Fya54smDXwV0+VU8PRakWl1//ZmXzGgZqh6 sINSZtlc9ccu8xdTcFTKpVS6uIiPHUK7T5RbmVyc= Date: Wed, 20 Jan 2021 18:17:35 +0100 From: Greg KH To: Hans de Goede Cc: Kyle Tso , linux@roeck-us.net, heikki.krogerus@linux.intel.com, badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/3] AMS, Collision Avoidance, and Protocol Error Message-ID: References: <20210114145053.1952756-1-kyletso@google.com> <2211ad43-b76c-fbe9-2cc8-bb40c4ee4e89@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2211ad43-b76c-fbe9-2cc8-bb40c4ee4e89@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 02:45:02PM +0100, Hans de Goede wrote: > Hi, > > On 1/14/21 3:50 PM, Kyle Tso wrote: > > v5 https://lore.kernel.org/r/20210105163927.1376770-1-kyletso@google.com > > > > "usb: typec: tcpm: AMS and Collision Avoidance" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - added FR_SWAP AMS handling > > > > "usb: typec: tcpm: Protocol Error handling" > > - removed the signed-off > > - modified the coding style suggested from Heikki > > - modified more coding style problems (line wrapping limit) > > > > "usb: typec: tcpm: Respond Wait if VDM state machine is running" > > - no change > > I've finally gotten around to testing this. I'm happy to > report that the power-role swapping regression seen in one > of the older versions of this patch-set is gone. > > So the entire series is: > Tested-by: Hans de Goede Thanks for testing and the review. Heikki, any thoughts? thanks, greg k-h