Re: [PATCH v4] Fixes: misc: rtsx: init value of aspm_enabled

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Jan 22, 2021 at 09:55:44AM +0000, 吳昊澄 Ricky wrote:
> > -----Original Message-----
> > From: Greg KH <gregkh@linuxfoundation.org>
> > Sent: Friday, January 22, 2021 4:28 PM
> > To: 吳昊澄 Ricky <ricky_wu@realtek.com>
> > Cc: arnd@arndb.de; bhelgaas@google.com; vaibhavgupta40@gmail.com;
> > linux-kernel@vger.kernel.org; stable@vger.kernel.org
> > Subject: Re: [PATCH v4] Fixes: misc: rtsx: init value of aspm_enabled
> > 
> > On Fri, Jan 22, 2021 at 04:19:06PM +0800, ricky_wu@realtek.com wrote:
> > > From: Ricky Wu <ricky_wu@realtek.com>
> > >
> > > make sure ASPM state sync with pcr->aspm_enabled init value
> > > pcr->aspm_enabled
> > >
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Ricky Wu <ricky_wu@realtek.com>
> > > ---
> > >
> > > v2: fixed conditions in v1 if-statement
> > > v3: give description for v1 and v2
> > > v4: move version change below ---
> > 
> > What commit id does this fix?  How far back should the stable backporting go?
> > That's what we use the Fixes: line for.
> > 
> I think I misunderstanding you
> Fix commit id:  d928061c3143de36c17650ce7b60760fefb8336c
> So I need to have v5 and add "Fixes:" tag like below in the signed off by area?

Yes.  See the many hundreds of examples of this on the mailing lists and
in the git log :)

> "Fixes: d928061c3143de36c17650ce7b60760fefb8336c"

It should be:
Fixes: d928061c3143 ("misc: rtsx: modify en/disable aspm function")

The submitting patches document should explain how to do that.

I can go and add it by hand for this, but next time, try to remember to
do it yourself.

thanks,

greg k-h