From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAE0DC433DB for ; Sun, 7 Feb 2021 14:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B148664E42 for ; Sun, 7 Feb 2021 14:56:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229698AbhBGOzv (ORCPT ); Sun, 7 Feb 2021 09:55:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:53926 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbhBGOzs (ORCPT ); Sun, 7 Feb 2021 09:55:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B15FE64E42; Sun, 7 Feb 2021 14:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612709707; bh=Wt9cjdwSLRzxXcychd1Z79SJy+jAFVnftbg1gVSar24=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eCM83IFX2LU1xrujsZe/0UxiWeKrZFGJO39/E/FowxMbokxCGvRoEsp48HVLkQ59B oY59k2lTJHBVkWhoaFXpher3PEhkasmDar6RqHuJVp7FmKprsqhdxCte8sYTHIo15y xYNl+3o4JG8JROMXqYZDQ88EkcrDBKthiMKgFdTc= Date: Sun, 7 Feb 2021 15:55:04 +0100 From: Greg KH To: Phillip Potter Cc: alexander.sverdlin@nokia.com, andrew@lunn.ch, davem@davemloft.net, chris.packham@alliedtelesis.co.nz, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: octeon: convert all uses of strlcpy to strscpy in ethernet-mdio.c Message-ID: References: <20210207144804.88330-1-phil@philpotter.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210207144804.88330-1-phil@philpotter.co.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 07, 2021 at 02:48:04PM +0000, Phillip Potter wrote: > Convert three calls to strlcpy inside the cvm_oct_get_drvinfo function > to strscpy calls. Fixes a style warning. Is it really safe to do this type of conversion here? If so, you need to provide evidence of it in the changelog, otherwise we could just do a search/replace across the whole kernel and be done with it :) thanks, greg k-h