From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C19C4C433DB for ; Sun, 7 Feb 2021 08:36:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5BE0E64DDC for ; Sun, 7 Feb 2021 08:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229623AbhBGIgB (ORCPT ); Sun, 7 Feb 2021 03:36:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:59594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbhBGIeM (ORCPT ); Sun, 7 Feb 2021 03:34:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id BC98C64E30; Sun, 7 Feb 2021 08:33:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612686809; bh=CRF6ov8HZYQgEMXDSLagshxMHLuVPb+BGxWwtc4e66E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nl8xpCtGkMfGXg5YCYtqrLhodKgeY4c/Lr9EQ6MkFxnx2AMTdNdR3SVtlsoRx9reB /wdrtE4kD398a4E08oKcvXYG9I+tX2kcIGJ8GlJ+rsd2HdRIF+myMP+uiNKT5P8HrR 0Ids3NNMBPsOx3loFGmyDQqqghGuIwGpCZHBKoH4= Date: Sun, 7 Feb 2021 09:33:26 +0100 From: Greg KH To: Kumar Kartikeya Dwivedi Cc: Stephen Rothwell , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: emxx_udc: Fix incorrectly defined global Message-ID: References: <20210207000030.256592-1-memxor@gmail.com> <20210207173441.2902acac@canb.auug.org.au> <20210207073827.7l7h3475tqgxxfte@apollo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210207073827.7l7h3475tqgxxfte@apollo> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 07, 2021 at 01:08:27PM +0530, Kumar Kartikeya Dwivedi wrote: > On Sun, Feb 07, 2021 at 12:04:41PM IST, Stephen Rothwell wrote: > > > > Given that drivers/staging/emxx_udc/emxx_udc.h is only included by > > drivers/staging/emxx_udc/emxx_udc.c, shouldn't these variables just be > > declared static in emxx_udc.c and removed from emxx_udc.h? > > > > Either would be correct. I went this way because it was originally trying to > (incorrectly) define a global variable instead. I guess they can be static now > and when more users are added, the linkage can be adjusted as needed. > > Here's another version of the patch: Please resend in the proper format that a second version of a patch should be in (the documentation describes how to do this.) thanks, greg k-h