From: Andrew Lunn <andrew@lunn.ch>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Takashi Iwai <tiwai@suse.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
"Matwey V. Kornilov" <matwey@sai.msu.ru>,
Robert Foss <robert.foss@linaro.org>
Subject: Re: [PATCH] media: pwc: Fix the URB buffer allocation
Date: Fri, 5 Feb 2021 13:53:21 +0100 [thread overview]
Message-ID: <YB0/wTjYqE9IgtXZ@lunn.ch> (raw)
In-Reply-To: <7afd0612-de36-60b1-6650-6f8de24a7145@xs4all.nl>
On Fri, Feb 05, 2021 at 01:36:43PM +0100, Hans Verkuil wrote:
> Hi Takashi,
>
> Thank you for this patch, but it clashes with another patch trying to do the same thing
> that has already been merged in our tree:
>
> https://patchwork.linuxtv.org/project/linux-media/patch/20210104170007.20625-1-matwey@sai.msu.ru/
>
> I do prefer your patch over the one already merged since it is a bit simpler, but
> shouldn't the calls to dma_sync_single_for_cpu() and dma_sync_single_for_device()
> in pwc-if.c also use urb->dev->bus->controller?
>
> Also, Matwey's patch uses urb->dev->bus->sysdev instead of urb->dev->bus->controller.
> How does 'sysdev' relate to 'controller'? I think 'controller' is the right device to
> use, but either seems to work when I test it with my pwc webcam.
Hi Hans
A quick grep in driver/usb show that all but one dma mapping operation
use sysdev. The one other case uses controller. So the numbers suggest
controller is wrong, sysdev is correct.
But maybe ask GregKH?
Andrew
next prev parent reply other threads:[~2021-02-05 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 20:28 Takashi Iwai
2021-01-22 8:57 ` Robert Foss
2021-02-05 12:36 ` Hans Verkuil
2021-02-05 12:53 ` Andrew Lunn [this message]
2021-02-05 13:03 ` Takashi Iwai
2021-02-05 13:13 ` Andrew Lunn
2021-02-05 13:42 ` Takashi Iwai
2021-02-05 13:53 ` Andrew Lunn
2021-02-05 14:05 ` Hans Verkuil
2021-02-05 14:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YB0/wTjYqE9IgtXZ@lunn.ch \
--to=andrew@lunn.ch \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matwey@sai.msu.ru \
--cc=mchehab@kernel.org \
--cc=robert.foss@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®