From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65817C433DB for ; Sat, 6 Feb 2021 04:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3147864FCA for ; Sat, 6 Feb 2021 04:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbhBFEO0 (ORCPT ); Fri, 5 Feb 2021 23:14:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232048AbhBFCuo (ORCPT ); Fri, 5 Feb 2021 21:50:44 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DFCCC08EE7F for ; Fri, 5 Feb 2021 16:40:11 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id s11so11131896edd.5 for ; Fri, 05 Feb 2021 16:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=yd9DVs1bpM3Y2tHW1e5fufzslh0L2frolGTr8VlBm1w=; b=hIqiPlRCktnGw29D8HqZEwtk/2+4Aty9eo+z/nKC5kuxzTo1rRn9Scus+6sMnqkx+d rvpWk0D4qKSZWNKef9hjzewXR+FFFt/YsBLuv7PvF7fLGaD6FRRKta0iB7kcRs7zM9ON g+djgut8H9myomPqLUkL1x7bDq1lccMg0mP88= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=yd9DVs1bpM3Y2tHW1e5fufzslh0L2frolGTr8VlBm1w=; b=rUoRdG3d7VhtEn6jnhbXtAcp7rkV8fFlt5RQt5NalQF8aA4Yh3r9PRmKkh9P7dt5VK fJye2t4KGzwsmGel0cEtPtPhtVf/Kgd3GdrXXyjOLOHFfcD1zc5PIdfzQXweRRkMEmcg BVajTg6t16wixDzdxxTMLcODrkSvi9zucnOPIh5spATySUp98B2nvxYSn22LxYeyo84n n0xydV876ZM3G24EXMRdsyVMWT89DAfKy3Dhiml3LuJrL94dXO4xvgkA0a+7GLJeFIpa kh+Vwh8WXrYzUdCrDK9FPbNCzRRvq7znyjWMKBFUC+TAy7ZvX6F87m27bARVaopGktOx s5wg== X-Gm-Message-State: AOAM530ntBZpojW2IjxmC/qJ0Gf/nB3QqvAGUaC/eLsxyd3bD0Udjh0p eQ0h40dzVQhfTScKa4B0pROo3Q== X-Google-Smtp-Source: ABdhPJxvlz9VFpro1BoxrP01rQJ4N6XwtZpuwm0SvnsLq5JrqOLFv6Dqdh/ANTeCcvFLAJqw6AsYbg== X-Received: by 2002:aa7:cfda:: with SMTP id r26mr6033955edy.142.1612572009688; Fri, 05 Feb 2021 16:40:09 -0800 (PST) Received: from localhost ([2620:10d:c093:400::4:4dd1]) by smtp.gmail.com with ESMTPSA id o4sm4759933edw.78.2021.02.05.16.40.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Feb 2021 16:40:09 -0800 (PST) Date: Sat, 6 Feb 2021 00:40:08 +0000 From: Chris Down To: Andrew Morton Cc: Seth Forshee , Hugh Dickins , Amir Goldstein , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tmpfs: Disallow CONFIG_TMPFS_INODE64 on s390 Message-ID: References: <20210205230620.518245-1-seth.forshee@canonical.com> <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210205160551.cf57c4293ba5ccb8eb648c11@linux-foundation.org> User-Agent: Mutt/2.0.5 (da5e3282) (2021-01-21) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: >Currently there is an assumption in tmpfs that 64-bit architectures also >have a 64-bit ino_t. This is not true on s390 which has a 32-bit ino_t. >With CONFIG_TMPFS_INODE64=y tmpfs mounts will get 64-bit inode numbers and >display "inode64" in the mount options, but passing the "inode64" mount >option will fail. This leads to the following behavior: > > # mkdir mnt > # mount -t tmpfs nodev mnt > # mount -o remount,rw mnt > mount: /home/ubuntu/mnt: mount point not mounted or bad option. > >As mount sees "inode64" in the mount options and thus passes it in the >options for the remount. > > >So prevent CONFIG_TMPFS_INODE64 from being selected on s390. > >Link: https://lkml.kernel.org/r/20210205230620.518245-1-seth.forshee@canonical.com >Fixes: ea3271f7196c ("tmpfs: support 64-bit inums per-sb") >Signed-off-by: Seth Forshee >Cc: Chris Down >Cc: Hugh Dickins >Cc: Amir Goldstein >Cc: Heiko Carstens >Cc: Vasily Gorbik >Cc: Christian Borntraeger >Cc: [5.9+] >Signed-off-by: Andrew Morton Either of the two ways presented looks fine to me, no real preference. Thanks! Acked-by: Chris Down >--- > > fs/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >--- a/fs/Kconfig~tmpfs-disallow-config_tmpfs_inode64-on-s390 >+++ a/fs/Kconfig >@@ -203,7 +203,7 @@ config TMPFS_XATTR > > config TMPFS_INODE64 > bool "Use 64-bit ino_t by default in tmpfs" >- depends on TMPFS && 64BIT >+ depends on TMPFS && 64BIT && !S390 > default n > help > tmpfs has historically used only inode numbers as wide as an unsigned >_ >