From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15CBC433E0 for ; Mon, 1 Feb 2021 07:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D85364DCC for ; Mon, 1 Feb 2021 07:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232286AbhBAHqa (ORCPT ); Mon, 1 Feb 2021 02:46:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:40502 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230174AbhBAHq3 (ORCPT ); Mon, 1 Feb 2021 02:46:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1057364E25; Mon, 1 Feb 2021 07:45:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612165548; bh=HfIKe4Ra643edjOVDok3KddUaSAgFo3c7mdIwt/sFF4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZndDGOnb8W6QTO8zoelUE9fEpJh7fciZYJVn/OwkbQpZsAjl/y5d+kIzi0Ez6YASu g/eDd7ex2B4dqbv/G0xD8tMFLdH6cwO2paifEXYIHeEo/Hz7xKOzGdQngtLZS3fWOl 4umaq1QLM9w65Qi/+5zcciL8wh0vEY5KjEOsKvvw= Date: Mon, 1 Feb 2021 08:45:44 +0100 From: Greg Kroah-Hartman To: Scott Branden Cc: Arnd Bergmann , Kees Cook , linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, Olof Johansson , Desmond Yan Subject: Re: [PATCH v3] misc: bcm-vk: only support ttyVK if CONFIG_TTY is set Message-ID: References: <20210131233049.5500-1-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210131233049.5500-1-scott.branden@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 31, 2021 at 03:30:49PM -0800, Scott Branden wrote: > Correct compile issue if CONFIG_TTY is not set by > only adding ttyVK devices if CONFIG_BCM_VK_TTY is set. > > Reported-by: Randy Dunlap > Signed-off-by: Scott Branden > > --- > Changes since v2: > - add CONFIG_BCM_VK_TTY > - add function and stub for bcm_vk_tty_set_irq_enabled > Changes since v1: > - add function stubs rather than compiling out code > --- > drivers/misc/bcm-vk/Kconfig | 16 ++++++++++++ > drivers/misc/bcm-vk/Makefile | 4 +-- > drivers/misc/bcm-vk/bcm_vk.h | 42 +++++++++++++++++++++++++++++--- > drivers/misc/bcm-vk/bcm_vk_dev.c | 5 ++-- > drivers/misc/bcm-vk/bcm_vk_tty.c | 6 +++++ > 5 files changed, 65 insertions(+), 8 deletions(-) > > diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig > index 052f6f28b540..16ce98c964b8 100644 > --- a/drivers/misc/bcm-vk/Kconfig > +++ b/drivers/misc/bcm-vk/Kconfig > @@ -15,3 +15,19 @@ config BCM_VK > accelerators via /dev/bcm-vk.N devices. > > If unsure, say N. > + > +if BCM_VK No need for this, just put it on the depends line, right? > + > +config BCM_VK_TTY > + bool "Enable ttyVK" Better config help text to explain what this is? > + depends on TTY > + default y Default y is only there if your system can not boot without it, please remove it. > + help > + Select this option to enable ttyVK support to allow console > + access to VK cards from host. Again, more help text, what is a "VK"? thanks, greg k-h