mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: eli.billauer@gmail.com
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] char: xillybus: Add driver for XillyUSB (Xillybus variant for USB)
Date: Mon, 1 Feb 2021 15:25:53 +0100	[thread overview]
Message-ID: <YBgPcX0J5m0bkhuA@kroah.com> (raw)
In-Reply-To: <20210201141651.62853-1-eli.billauer@gmail.com>

On Mon, Feb 01, 2021 at 04:16:51PM +0200, eli.billauer@gmail.com wrote:
> From: Eli Billauer <eli.billauer@gmail.com>
> 
> The XillyUSB driver is the USB variant for the Xillybus FPGA IP core.
> Even though it presents a nearly identical API on the FPGA and host,
> it's almost a complete rewrite of the driver: The framework for exchanging
> data on a USB bus is fundamentally different from doing the same with a
> PCIe interface, which leaves very little in common between the existing
> driver and the new one for XillyUSB.

As this has nothing to do with the existing XillyBus code, and you
aren't doing anything "fancy" with the character device nodes, why does
this need to be a kernel driver at all?  Why can't you just use libusb
and talk to the device directly from userspace with no kernel driver
needed?

And always cc: linux-usb@vger.kernel.org when submitting a USB driver so
that the developers there can review it.

thanks,

greg k-h

  reply	other threads:[~2021-02-01 14:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 14:16 eli.billauer
2021-02-01 14:25 ` Greg KH [this message]
2021-02-01 15:56   ` Eli Billauer
2021-02-01 16:04     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBgPcX0J5m0bkhuA@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=eli.billauer@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®