From: Greg KH <gregkh@linuxfoundation.org>
To: Benson Leung <bleung@google.com>
Cc: Benson Leung <bleung@chromium.org>,
heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com,
pmalani@chromium.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, groeck@chromium.org
Subject: Re: [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers
Date: Tue, 2 Feb 2021 08:32:06 +0100 [thread overview]
Message-ID: <YBj/9tP7b4CgeZ8r@kroah.com> (raw)
In-Reply-To: <YBj5b7O60c6fh/nX@google.com>
On Mon, Feb 01, 2021 at 11:04:15PM -0800, Benson Leung wrote:
> Hi Greg,
>
> On Mon, Feb 01, 2021 at 03:32:47PM +0100, Greg KH wrote:
> > On Thu, Jan 28, 2021 at 10:14:00PM -0800, Benson Leung wrote:
> > > USB Power Delivery has a 3 entity handshake (port, cable, partner), and as
> > > of USB PD R3.0, each entity may independently support either Revision 2 or
> > > Revision 3 signaling and protocol. In order for userspace and the kernel
> > > to properly process the data objects received from a particular SOP*, we
> > > must know to which revision of the spec each conforms.
> > >
> > > This series adds individual version numbers for the partner and the cable,
> > > and exposes them in the appropriate sysfs in /sys/class/typec.
> > >
> > > I provide as a first implementation of this, platform/chrome's cros_ec_typec
> > > driver, whose underlying status messages convey the SOP and SOP' revisions
> > > already.
> >
> > I've taken the first 3 patches in my tree now, but the last 3 (for the
> > chrome_ec_typec.c driver), they do not apply at all.
> >
>
> Ah, that's because we have some other changes for the cros_ec_typec.c driver
> already in platform/chrome for our 5.12 branch.
>
> For 5.12, the changes for cros_ec_typec driver is pretty well contained,
> although there is some dependence on typec subsystem changes now.
>
> If I send you a pull request containing all of the changes for this driver we
> have already merged, plus these last three that depend on both of our trees
> would you merge it through usb for 5.12?
If the subsystem maintainer says it is ok, yes, I will be glad to take a
stable git tag to pull from into my usb-next branch.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-02 7:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 6:14 Benson Leung
2021-01-29 6:14 ` [PATCH 1/6] usb: typec: Standardize PD Revision format with Type-C Revision Benson Leung
2021-02-01 12:38 ` Heikki Krogerus
2021-01-29 6:14 ` [PATCH 2/6] usb: typec: Provide PD Specification Revision for cable and partner Benson Leung
2021-02-01 12:40 ` Heikki Krogerus
2021-01-29 6:14 ` [PATCH 3/6] usb: typec: Add typec_partner_set_pd_revision Benson Leung
2021-02-01 12:41 ` Heikki Krogerus
2021-01-29 6:14 ` [PATCH 4/6] platform/chrome: cros_ec_typec: Report SOP' PD revision from status Benson Leung
2021-02-01 12:51 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:12 ` Prashant Malani
2021-01-29 6:14 ` [PATCH 5/6] platform/chrome: cros_ec_typec: Set Partner " Benson Leung
2021-02-01 12:52 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:13 ` Prashant Malani
2021-01-29 6:14 ` [PATCH 6/6] platform/chrome: cros_ec_typec: Set opmode to PD on SOP connected Benson Leung
2021-02-01 12:55 ` Heikki Krogerus
2021-02-01 14:33 ` Enric Balletbo i Serra
2021-02-01 18:15 ` Prashant Malani
2021-02-01 14:32 ` [PATCH 0/6] usb: typec: and platform/chrome: Add PD revision numbers Greg KH
2021-02-02 7:04 ` Benson Leung
2021-02-02 7:32 ` Greg KH [this message]
2021-02-01 14:37 ` Enric Balletbo i Serra
2021-02-01 14:43 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBj/9tP7b4CgeZ8r@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome