From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6044DC433E6 for ; Wed, 3 Feb 2021 14:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DA8A64F6C for ; Wed, 3 Feb 2021 14:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233199AbhBCOuA (ORCPT ); Wed, 3 Feb 2021 09:50:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232960AbhBCOtt (ORCPT ); Wed, 3 Feb 2021 09:49:49 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 583CEC0613ED for ; Wed, 3 Feb 2021 06:49:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q5yIzcjFFGMD5Gmak358b/nkkqOjGxCgXaPOO2AW0ms=; b=lesWGBdhwB2V0dWkJr6332TBUR MHt/e+LE+gcSRU8YnKGTPi1knVebEeFym8hGMeB3hKl/BI+wMn4S6A4RuAV4CK43/QaqElQsop8BH L0K179MfOZ5ozdcSkiyS/OO1HDYcAfu8soL6l5i6lMXzP4MKzztY4hZfbuMVVN0cAUhfNMdFiKvrs i+/h75ie7zkK4f4l3N7iZGTNCL2KJDtW9V35gu7HcOURERJ61WL+WYHTPzBayHiVTxFdHR+HJZ5nd zpgrXHkszj5Lo558C+hyVYavCpsHK6wfj06TzpUbPRQ+oi/PHs4n5gL00n53ixxM3E5Qoh2dkYUG2 +m7kTFmg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1l7JSo-00H38b-SL; Wed, 03 Feb 2021 14:49:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 8850030066E; Wed, 3 Feb 2021 15:49:02 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 7337120C633CC; Wed, 3 Feb 2021 15:49:02 +0100 (CET) Date: Wed, 3 Feb 2021 15:49:02 +0100 From: Peter Zijlstra To: Josh Poimboeuf Cc: Thomas Gleixner , Miroslav Benes , Nick Desaulniers , Julien Thierry , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] objtool: Change REG_SP_INDIRECT Message-ID: References: <20210203120222.451068583@infradead.org> <20210203120401.062155900@infradead.org> <20210203144215.4ledy6srx7zwfxde@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203144215.4ledy6srx7zwfxde@treble> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 08:42:15AM -0600, Josh Poimboeuf wrote: > On Wed, Feb 03, 2021 at 01:02:23PM +0100, Peter Zijlstra wrote: > > Currently REG_SP_INDIRECT is unused but means (%rsp + offset), > > change it to mean (%rsp) + offset. > > > > This is somewhat unfortunate, since REG_BP_INDIRECT is used (by DRAP) > > and thus needs to retain the current (%rbp + offset). > > Offset is going to be zero, should it not work either way? For DRAP? I couldn't tell in a hurry. I'm ever quite clear on how DRAP works. Some day, when I figure it out, i'll write a comment. Anyway, if it's always 0 for DRAP, then yes, I'll change both.