From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC74C433E6 for ; Wed, 3 Feb 2021 18:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E96F364F61 for ; Wed, 3 Feb 2021 18:35:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232750AbhBCSe4 (ORCPT ); Wed, 3 Feb 2021 13:34:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232404AbhBCSeo (ORCPT ); Wed, 3 Feb 2021 13:34:44 -0500 Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40498C061786 for ; Wed, 3 Feb 2021 10:34:04 -0800 (PST) Received: by mail-ot1-x335.google.com with SMTP id e70so788484ote.11 for ; Wed, 03 Feb 2021 10:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=b/h61WQmUl7DxkrOa+nJW5VWfeQ3jtDfBJrjGAKSiWg=; b=th7nHy8TMGvd77hm3VatWAIKwQwqkGfYpRxIpabbNdRxzotHf5qHiXX/1fD0efLp/b rvwX1ZlFPrFR3IMLR0siUmShoamKB7xNf0Udcssb+EVePnGR9uj+zoQLIQu1ZQSC/+0D jUp0DYbSf4sqTOGzhObh551zlqJbH/sJIAxlaw7bFs1uFkTrbW6s1PkEE6BFtKn8SRtT ISvaO/9m1pUx1V5+VYkuxY8upkPtw8vvuDNGjC8C/OaRoKnfNn5CZQeQoDi4kFs0kfr4 jnCeXpED7dCMeFRQbO3RUamk2WW8Ch53SNPTmyl5cV6gly5wp7HWKf+9vb5XVmsqIT5Z IBug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b/h61WQmUl7DxkrOa+nJW5VWfeQ3jtDfBJrjGAKSiWg=; b=kpAmt9+vWWOMgWJkgvLp7nPdXhemdi5g5UyDBAtnw+tIy0wvFCfcXn74iHADP/NkUb iAEVe5T8sJEsKXv2F/01HA6q+qH3IUhhzMiuEM0lcwejg+kSKJw/PMOl3QGeeIxUYLUW zTA8y+A8TTPTJkIVb/B1c8YfkBgmrRop6QVcPph/FbIMKS6taDgjEGnP5j31y4GkTjyN GbMrQ6rdTMMmZByAE/M6hP59YorTtEPK6iY4FXxLJTa1Ypfk3A7cLdTIX5tX0FbjVU9d pm8UJHKl1Ao7S4FuDxPcgsd7KbLYb155VDk1pMsH9hhuwhhZw+8jbcCf7FDq5ApSc3rY V36Q== X-Gm-Message-State: AOAM531Z+38jeQo1MDO3PK6Uq+iiypzCzUOQzd58qWG242yeai8y+Jaq sxvBqlyP7eNSapVbHKAii/mMIQ== X-Google-Smtp-Source: ABdhPJzX5bEPWeTsKmXSVCVyB+BEQNGvGEz8pjvBUPD+m7MKvasqadpfTT/hujD0044pXJGP6otwiA== X-Received: by 2002:a9d:d10:: with SMTP id 16mr3089686oti.101.1612377243532; Wed, 03 Feb 2021 10:34:03 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id t2sm579489otj.47.2021.02.03.10.34.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Feb 2021 10:34:02 -0800 (PST) Date: Wed, 3 Feb 2021 12:34:00 -0600 From: Bjorn Andersson To: Jakub Kicinski Cc: Manivannan Sadhasivam , Greg KH , davem@davemloft.net, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, jhugo@codeaurora.org, bbhatt@codeaurora.org, loic.poulain@linaro.org, netdev@vger.kernel.org Subject: Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver Message-ID: References: <1609958656-15064-1-git-send-email-hemantk@codeaurora.org> <20210113152625.GB30246@work> <20210201105549.GB108653@thinkpad> <20210201121322.GC108653@thinkpad> <20210202042208.GB840@work> <20210202201008.274209f9@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <835B2E08-7B84-4A02-B82F-445467D69083@linaro.org> <20210203100508.1082f73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203100508.1082f73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 03 Feb 12:05 CST 2021, Jakub Kicinski wrote: > On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote: > > >> Jakub, Dave, Adding you both to get your reviews on this series. I've > > >> provided an explanation above and in the previous iteration [1]. > > > > > >Let's be clear what the review would be for. Yet another QMI chardev > > >or the "UCI" direct generic user space to firmware pipe? > > > > The current patchset only supports QMI channel so I'd request you to > > review the chardev node created for it. The QMI chardev node created > > will be unique for the MHI bus and the number of nodes depends on the > > MHI controllers in the system (typically 1 but not limited). > > If you want to add a MHI QMI driver, please write a QMI-only driver. But said QMI driver would be identical to what is proposed here, given that the libqmi [1] communicates in the raw messages of the given MHI channel. Should I then propose another copy of the same driver for transporting debug messages between [2] and the modem? And a third copy to support firmware flashing using [3]. [1] https://www.freedesktop.org/wiki/Software/libqmi/ [2] https://github.com/andersson/diag [3] https://github.com/andersson/qdl > This generic "userspace client interface" driver is a no go. Nobody will > have the time and attention to police what you throw in there later. PCI devices implementing this must have a MHI controller driver, which explicitly needs to specify which logical channels should be exposed to userspace using the UCI driver. So in contrast to things like USBFS or the tty layer - which is used to implement "network devices" today - there is a natural point of policing this. Regards, Bjorn