From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC20FC433E0 for ; Thu, 4 Feb 2021 15:31:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79B4B64DF5 for ; Thu, 4 Feb 2021 15:31:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237364AbhBDPbB (ORCPT ); Thu, 4 Feb 2021 10:31:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:53968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237325AbhBDP3k (ORCPT ); Thu, 4 Feb 2021 10:29:40 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1CEEE64DF5; Thu, 4 Feb 2021 15:28:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612452539; bh=I6xC+Xl7rj9KjJh8OT+FRp7sxPgM1E+61VHhivEMUsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WcRZnvioNG7VFrSgWK+Z0q9blvJWKlVZ/fNFQTAkkNlXRbtu4XZ8YY6wTdroBK/q+ buNdv8g6BFDyuzSm6z/vgjSGHhnA39A3zw6/geD5Ho+lkj03jRecRw9hCzWKz7TnPf L6QV8t86Vh+YIHEdlCZDx3Wnz3FaRCdaxFpEwBF8= Date: Thu, 4 Feb 2021 16:28:56 +0100 From: Greg Kroah-Hartman To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Kent Gibson , Linus Walleij , linux-gpio , LKML Subject: Re: [PATCH] gpio: uapi: use the preferred SPDX license identifier Message-ID: References: <20210204124357.3817-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 04, 2021 at 04:17:51PM +0100, Bartosz Golaszewski wrote: > On Thu, Feb 4, 2021 at 3:35 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Feb 04, 2021 at 03:15:50PM +0100, Bartosz Golaszewski wrote: > > > On Thu, Feb 4, 2021 at 2:47 PM Greg Kroah-Hartman > > > wrote: > > > > > > > > On Thu, Feb 04, 2021 at 01:43:57PM +0100, Bartosz Golaszewski wrote: > > > > > From: Bartosz Golaszewski > > > > > > > > > > GPL-2.0 license identifier is deprecated, let's use the preferred > > > > > identifier: GPL-2.0-only. > > > > > > > > > > Signed-off-by: Bartosz Golaszewski > > > > > --- > > > > > Hi Kent, Greg, > > > > > > > > > > I started working on making libgpiod licensing reuse-compliant and noticed > > > > > that the reuse-tool is telling me that the GPL-2.0 SPDX identifier in the > > > > > GPIO uapi header is deprecated. Since I'm required to copy the header > > > > > verbatim into libgpiod's repository, I think we need to fix that at source > > > > > first. > > > > > > > > > > include/uapi/linux/gpio.h | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/include/uapi/linux/gpio.h b/include/uapi/linux/gpio.h > > > > > index e4eb0b8c5cf9..3e01ededbf36 100644 > > > > > --- a/include/uapi/linux/gpio.h > > > > > +++ b/include/uapi/linux/gpio.h > > > > > @@ -1,4 +1,4 @@ > > > > > -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > > +/* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */ > > > > > > > > No, there is no need to convert the kernel to the "latest" spdx level, > > > > when we started out there was no "-only" nonsense (hint no other license > > > > has that crud), and "GPL-2.0" is a totally valid summary of the license. > > > > > > > > So please don't go changing it all in-kernel, that way lies madness. > > > > Let's finish fixing up ALL kernel files before worrying about what SPDX > > > > "version" we are at. > > > > > > > > > > But then, the reuse script is telling me: > > > > > > Unfortunately, your project is not compliant with version 3.0 of > > > the REUSE Specification :-( > > > > > > because I'm using a deprecated license. :( > > > > Go yell at the REUSE people, there's no requirement to have the most > > recent version of SPDX, is there? :) > > > > And if that's the only thing wrong with the project when running 'reuse > > lint' then you should be happy, no one will complain at all. > > > > thanks, > > > > greg k-h > > Ok, I get it but let me try one last time: there's absolutely no harm > in merging this patch for the next release, is there? Currently there > are around 15000 instances of "GPL-2.0-only" in the kernel vs 30000 > "GPL-2.0" - so the former is not that uncommon. It's up to the owner/maintainer of this file in the end, but I don't want to see patches doing this for many more files, as it's pointless churn as far as the kernel is concerned. thanks, greg k-h