From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B1CEC433DB for ; Fri, 19 Feb 2021 13:44:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C54A764ED2 for ; Fri, 19 Feb 2021 13:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230280AbhBSNoJ (ORCPT ); Fri, 19 Feb 2021 08:44:09 -0500 Received: from mga01.intel.com ([192.55.52.88]:8794 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbhBSNn7 (ORCPT ); Fri, 19 Feb 2021 08:43:59 -0500 IronPort-SDR: zFU465set7nEVqTudvGcSn+AvXkOd5/0sUGqhJ+JV2HUmSKVGgl5Q09Ux2IMTeovMiPHyDbyZo SJCM/xxqRr6g== X-IronPort-AV: E=McAfee;i="6000,8403,9899"; a="203127216" X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="203127216" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 05:42:11 -0800 IronPort-SDR: ClK7nKCC1NulLIONlpcICidg6Ynxo/EEYGHIufPxGJaaeBPafFG6nuKeA6I6Ai7mbltlmZCe6Q YCRPUvHOeB+w== X-IronPort-AV: E=Sophos;i="5.81,189,1610438400"; d="scan'208";a="440260183" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Feb 2021 05:42:09 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lD62o-006Dr5-O8; Fri, 19 Feb 2021 15:42:06 +0200 Date: Fri, 19 Feb 2021 15:42:06 +0200 From: Andy Shevchenko To: Pavel Machek Cc: Dan Murphy , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 6/7] leds: lp50xx: Add missed bits.h and convert to BIT() Message-ID: References: <20210216155050.29322-1-andriy.shevchenko@linux.intel.com> <20210216155050.29322-6-andriy.shevchenko@linux.intel.com> <20210219112755.GN19207@duo.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210219112755.GN19207@duo.ucw.cz> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 12:27:55PM +0100, Pavel Machek wrote: > Hi! > > > Add missed bits.h and convert to BIT() in lp50xx_set_banks(). > > > > Signed-off-by: Andy Shevchenko > > Thanks, Thanks! > I applied whole series except this one... > > << is well known C, it can stay. Shall we drop BIT() in the other place? Otherwise it is inconsistency. -- With Best Regards, Andy Shevchenko