From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2C6EC433DB for ; Thu, 18 Feb 2021 08:21:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5D66264DFF for ; Thu, 18 Feb 2021 08:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230450AbhBRIUS (ORCPT ); Thu, 18 Feb 2021 03:20:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:37124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231168AbhBRHVB (ORCPT ); Thu, 18 Feb 2021 02:21:01 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id CBC7164D9F; Thu, 18 Feb 2021 07:10:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613632232; bh=V0ObLKL8xMIPQWZ+Z7mEwookFjTJoIGtHvN+xm7+Rwk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VCWvovz1y5axANTN4LfJQ8h4mwNxCRNI2xggDWg3Aey16+TaiWX7tCnMcYQfKvN/o HfqLvm3frRgElCkITrRVi/1LkZrwaAWW2nOXPHjW1IZ7Hp0G36NuA86sZg9P9CtqKB 87JPZv3o63E7vCx0wyGKHDmx3bYS9yS8s7LI2JIk= Date: Thu, 18 Feb 2021 08:10:28 +0100 From: Greg KH To: Atul Gopinathan Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: comedi: cast to (void __user *) Message-ID: References: <20210218062839.32650-1-atulgopinathan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210218062839.32650-1-atulgopinathan@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 18, 2021 at 11:58:40AM +0530, Atul Gopinathan wrote: > Resolve the following sparse warning: > drivers/staging//comedi/comedi_fops.c:2983:41: warning: incorrect type in argument 1 (different address spaces) > drivers/staging//comedi/comedi_fops.c:2983:41: expected void [noderef] *uptr > drivers/staging//comedi/comedi_fops.c:2983:41: got unsigned int *chanlist > > cmd->chanlist is of type (unsigned int *) as defined in > "struct comedi_cmd" in file drivers/staging/comedi/comedi.h > > The function "ptr_to_compat()" expects argument of type > (void __user *) as defined in include/linux/compat.h > > Signed-off-by: Atul Gopinathan > --- > drivers/staging/comedi/comedi_fops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Is this different from your previous patch: https://lore.kernel.org/r/20210217165907.9777-1-atulgopinathan@gmail.com if so, you might need a better subject line here, and for that one, as they look alike at a quick glance. Which one goes first? Can you resend both of these as a patch series with better subjects as a v2 patch set? thanks, greg k-h