From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F05DC433DB for ; Fri, 19 Feb 2021 06:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E03BC6186A for ; Fri, 19 Feb 2021 06:22:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229708AbhBSGWC (ORCPT ); Fri, 19 Feb 2021 01:22:02 -0500 Received: from mail.kernel.org ([198.145.29.99]:57506 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbhBSGV6 (ORCPT ); Fri, 19 Feb 2021 01:21:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 887B064EC0; Fri, 19 Feb 2021 06:21:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613715677; bh=h3tseLehzsIKBNkS/hC8AI0YOI2QV+D0PG4f72kEZAI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gus+0Z73eMJkwwPTaT5qMZFzGQWGL7AebpV+mEPFEU53PhlTUJJa4rSQnR3BqN2t6 yA/0uw3N2BJynAuBRk84kmUPFjNs1pErofcDpXsQqyZpBWfZODjhvn3VuCY4h5f+tu joChh/mOcik/mF4PWQhMw7EvbVrYeGsV18fosH80= Date: Fri, 19 Feb 2021 07:21:13 +0100 From: Greg Kroah-Hartman To: karthik alapati Cc: Lee Jones , Johannes Berg , Arnd Bergmann , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: i2400m: use explicit host byte-order types in comparison Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 19, 2021 at 06:00:47AM +0530, karthik alapati wrote: > convert le32 types to host byte-order types before > comparison That says what you did, but not _why_ you did it. Please fix up and resend. thanks, greg k-h