From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CADC433E0 for ; Fri, 19 Feb 2021 08:12:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05D2464EB8 for ; Fri, 19 Feb 2021 08:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229800AbhBSIMZ (ORCPT ); Fri, 19 Feb 2021 03:12:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:57008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229481AbhBSIMX (ORCPT ); Fri, 19 Feb 2021 03:12:23 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 70CF264EBD; Fri, 19 Feb 2021 08:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613722302; bh=EwTC9tC7yHKIbAicSsPxDq3xGvNVTspmTrJcExiOpVs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CWW1QIfS/Ebz56dRe4M5R1jmpuGnSj75KXXk4Cehdx2kmxYtDfTKrnSIW3LZ0ZYjH V05uYp0SjJO32hJViLlYWzxgupMAIOXuISKRis892OcVwDJe119c7VaqLYPmYBLnRy zx7rrh7kriouzpBrdf/v9KGI7yRDZPOmnR/snJBw= Date: Fri, 19 Feb 2021 09:11:39 +0100 From: Greg KH To: Alaa Emad Cc: mchehab+huawei@kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: hikey9xx: fix styling issues Message-ID: References: <20210216124255.9353-1-alaaemadhossney.ae@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216124255.9353-1-alaaemadhossney.ae@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 16, 2021 at 02:42:55PM +0200, Alaa Emad wrote: > In hi6421-spmi-pmic.c, there are some warnings and Check: > > "WARNING: please, no space before tabs" in lines 51,52,53 and 69. > "CHECK: Alignment should match open parenthesis" in lines 180 and 238. > > Signed-off-by: Alaa Emad That is doing 2 different things in the same patch, please make this a patch series and do only one type of logical thing per patch and resend them. thanks, greg k-h