From: Peter Zijlstra <peterz@infradead.org>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Miroslav Benes <mbenes@suse.cz>,
Nick Desaulniers <ndesaulniers@google.com>,
Julien Thierry <jthierry@redhat.com>,
Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2.1 2/3] objtool,x86: Additionally decode: mov %rsp, (%reg)
Date: Wed, 10 Feb 2021 10:31:06 +0100 [thread overview]
Message-ID: <YCOn2uzMFnT4Y/yp@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <YCOiowWtr8XTT+mN@hirez.programming.kicks-ass.net>
On Wed, Feb 10, 2021 at 10:08:51AM +0100, Peter Zijlstra wrote:
> + /* skip nontrivial SIB */
> + if (modrm_rm == 4 && sib != 0x24)
> + break;
Hmm,, maybe that should be:
if (modrm_rm == 4 && !(sib == 0x24 && rex_b == rex_x))
Because what we have is that once we have a SIB byte, rex_b is for
sib_base and rex_x is always sib_index, and we need to ensure that
sib_base == sib_index for the trivial case.
/me changes...
next prev parent reply other threads:[~2021-02-10 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 9:16 [PATCH v2 0/3] objtool: Support the stack swizzle Peter Zijlstra
2021-02-09 9:16 ` [PATCH v2 1/3] x86/unwind/orc: Change REG_SP_INDIRECT Peter Zijlstra
2021-02-09 9:16 ` [PATCH v2 2/3] objtool,x86: Additionally decode: mov %rsp, (%reg) Peter Zijlstra
2021-02-09 16:32 ` Josh Poimboeuf
2021-02-09 16:42 ` Peter Zijlstra
2021-02-10 9:08 ` [PATCH v2.1 " Peter Zijlstra
2021-02-10 9:31 ` Peter Zijlstra [this message]
2021-02-09 9:16 ` [PATCH v2 3/3] objtool: Support stack-swizzle Peter Zijlstra
2021-02-09 10:35 ` Peter Zijlstra
2021-02-09 15:45 ` [PATCH v2 0/3] objtool: Support the stack swizzle Miroslav Benes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCOn2uzMFnT4Y/yp@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=jthierry@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®