From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADCEC433E6 for ; Mon, 15 Feb 2021 17:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73E9D64DDA for ; Mon, 15 Feb 2021 17:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232535AbhBORM4 (ORCPT ); Mon, 15 Feb 2021 12:12:56 -0500 Received: from mga05.intel.com ([192.55.52.43]:33146 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232091AbhBOQBd (ORCPT ); Mon, 15 Feb 2021 11:01:33 -0500 IronPort-SDR: O5hpvc2A4AQ0VWOvXQfCRBGiK37lI80cxYgoOh/+d6R2I4wCYoZC4WuS1+ywvaaD4xJkXVAN6O ZJINbiTWkYiA== X-IronPort-AV: E=McAfee;i="6000,8403,9896"; a="267558229" X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="267558229" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 07:58:55 -0800 IronPort-SDR: qUBcDnMNGWB44uoh1MTupZsdb45fxio3m0E/f9VI6r96twT5vE68fSmGs0x7S+Ia9ZGYH1KBSs erfQ6tr1Worg== X-IronPort-AV: E=Sophos;i="5.81,181,1610438400"; d="scan'208";a="580213026" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2021 07:58:50 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lBgGs-005GNG-Ra; Mon, 15 Feb 2021 17:58:46 +0200 Date: Mon, 15 Feb 2021 17:58:46 +0200 From: Andy Shevchenko To: Jani Nikula Cc: Alex Deucher , Mikita Lipski , Eryk Brol , Chris Wilson , "David S. Miller" , Rahul Lakkireddy , Francis Laniel , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, netdev@vger.kernel.org, Harry Wentland , Leo Li , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Daniel Vetter , Joonas Lahtinen , Rodrigo Vivi , Raju Rangoju , Jakub Kicinski Subject: Re: [PATCH v1 1/3] string: Consolidate yesno() helpers under string.h hood Message-ID: References: <20210215142137.64476-1-andriy.shevchenko@linux.intel.com> <87y2fpbdmp.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y2fpbdmp.fsf@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 15, 2021 at 04:37:50PM +0200, Jani Nikula wrote: > On Mon, 15 Feb 2021, Andy Shevchenko wrote: > > We have already few similar implementation and a lot of code that can benefit > > of the yesno() helper. Consolidate yesno() helpers under string.h hood. > > Good luck. I gave up after just four versions. [1] Thanks for a pointer! I like your version, but here we also discussing a possibility to do something like %py[DOY]. It will consolidate all those RO or whatever sections inside one data structure. > Acked-by: Jani Nikula > > [1] http://lore.kernel.org/r/20191023131308.9420-1-jani.nikula@intel.com -- With Best Regards, Andy Shevchenko