From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238FEC433DB for ; Mon, 1 Mar 2021 16:21:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0FFB64F45 for ; Mon, 1 Mar 2021 16:21:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235420AbhCAQV1 (ORCPT ); Mon, 1 Mar 2021 11:21:27 -0500 Received: from mga07.intel.com ([134.134.136.100]:17862 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237711AbhCAQQq (ORCPT ); Mon, 1 Mar 2021 11:16:46 -0500 IronPort-SDR: t4fjTksnBDKJ1ph33VmwF5Ksx3wyOS7H69HTCVyfmHOky8IVEpOFDOSJFoTzofUCinLz3ScikL G24GWIL4WYoQ== X-IronPort-AV: E=McAfee;i="6000,8403,9910"; a="250563396" X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="250563396" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 08:14:41 -0800 IronPort-SDR: HzQaJm9eeK4W/urB5M8RAw/tPfIcmkMZr1w2Q6JtbPibE7PInLIL5HnGyj6Hs+PPcWD3bz/mV7 fAwWikIHtdlg== X-IronPort-AV: E=Sophos;i="5.81,215,1610438400"; d="scan'208";a="366755699" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2021 08:14:40 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lGlBt-009BNW-LW; Mon, 01 Mar 2021 18:14:37 +0200 Date: Mon, 1 Mar 2021 18:14:37 +0200 From: Andy Shevchenko To: Jiri Kosina Cc: Benjamin Tissoires , Douglas Anderson , "open list:HID CORE LAYER" , lkml Subject: Re: [PATCH v2 4/4] HID: i2c-hid: acpi: Drop redundant ACPI_PTR() Message-ID: References: <20210226193225.47129-1-andriy.shevchenko@linux.intel.com> <20210226193225.47129-4-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 04:34:41PM +0100, Jiri Kosina wrote: > On Mon, 1 Mar 2021, Benjamin Tissoires wrote: > > On Fri, Feb 26, 2021 at 8:34 PM Andy Shevchenko > > wrote: > > > > > > The driver depends on ACPI, ACPI_PTR() resolution is always the same. > > > Otherwise a compiler may produce a warning. > > > > > > That said, the rule of thumb either ugly ifdeffery with ACPI_PTR or > > > none should be used in a driver. > > > > > > Signed-off-by: Andy Shevchenko > > > > Thanks a lot for the series. This indeed cleans things up. > > Indeed, thanks. > > > For the series: > > Acked-by: Benjamin Tissoires > > > > Jiri, I wonder where we want to land this one. This is not strictly > > bug fixes, but we could definitively sneak this one in 5.12-rc1. > > Well, I should probably run the series on an acpi laptop here before > > merging, but I'd like to know if delaying to 5.13 is OK or if we need > > this in 5.12. > > I'd like to do it the standard way and have it bake in for-next to see if > it really doesn't break anything, so unless there are convicing arguments > for 5.12-rcX, I'd rathre queue this for 5.13. For the record, I'm not in hurry with this, up to you how to proceed. Thanks! -- With Best Regards, Andy Shevchenko