From: Peter Zijlstra <peterz@infradead.org>
To: Feng Tang <feng.tang@intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, H Peter Anvin <hpa@zytor.com>,
Borislav Petkov <bp@alien8.de>,
x86@kernel.org, linux-kernel@vger.kernel.org,
rui.zhang@intel.com, dave.hansen@intel.com, andi.kleen@intel.com,
len.brown@intel.com
Subject: Re: [PATCH] x86/tsc: mark tsc reliable for qualified platforms
Date: Tue, 2 Mar 2021 10:14:01 +0100 [thread overview]
Message-ID: <YD4B2TG7JPqFChhR@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1614653572-19941-1-git-send-email-feng.tang@intel.com>
On Tue, Mar 02, 2021 at 10:52:52AM +0800, Feng Tang wrote:
> @@ -1193,6 +1193,17 @@ static void __init check_system_tsc_reliable(void)
> #endif
> if (boot_cpu_has(X86_FEATURE_TSC_RELIABLE))
> tsc_clocksource_reliable = 1;
> +
> + /*
> + * Ideally the socket number should be checked, but this is called
> + * by tsc_init() which is in early boot phase and the socket numbers
> + * may not be available. Use 'nr_online_nodes' as a fallback solution
> + */
> + if (boot_cpu_has(X86_FEATURE_CONSTANT_TSC)
> + && boot_cpu_has(X86_FEATURE_NONSTOP_TSC)
> + && boot_cpu_has(X86_FEATURE_TSC_ADJUST)
> + && nr_online_nodes <= 2)
> + tsc_clocksource_reliable = 1;
Logical operators go at the end of a line and alignment is with the (,
not the code block after it.
next prev parent reply other threads:[~2021-03-02 9:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 2:52 Feng Tang
2021-03-02 9:14 ` Peter Zijlstra [this message]
2021-03-02 11:55 ` Feng Tang
2021-03-03 14:51 ` Thomas Gleixner
2021-03-08 1:42 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4B2TG7JPqFChhR@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi.kleen@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=feng.tang@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rui.zhang@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®