From: Peter Zijlstra <peterz@infradead.org>
To: Feng Tang <feng.tang@intel.com>
Cc: John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org, Qais Yousef <qais.yousef@arm.com>,
andi.kleen@intel.com
Subject: Re: [PATCH] clocksource: don't run watchdog forever
Date: Tue, 2 Mar 2021 10:16:37 +0100 [thread overview]
Message-ID: <YD4CdQqX5Lea1rB5@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1614653665-20905-1-git-send-email-feng.tang@intel.com>
On Tue, Mar 02, 2021 at 10:54:24AM +0800, Feng Tang wrote:
> clocksource watchdog runs every 500ms, which creates some OS noise.
> As the clocksource wreckage (especially for those that has per-cpu
> reading hook) usually happens shortly after CPU is brought up or
> after system resumes from sleep state, so add a time limit for
> clocksource watchdog to only run for a period of time, and make
> sure it run at least twice for each CPU.
>
> Regarding performance data, there is no improvement data with the
> micro-benchmarks we have like hackbench/netperf/fio/will-it-scale
> etc. But it obviously reduces periodic timer interrupts, and may
> help in following cases:
> * When some CPUs are isolated to only run scientific or high
> performance computing tasks on a NOHZ_FULL kernel, where there
> is almost no interrupts, this could make it more quiet
> * On a cluster which runs a lot of systems in parallel with
> barriers there are always enough systems which run the watchdog
> and make everyone else wait
>
> Signed-off-by: Feng Tang <feng.tang@intel.com>
Urgh.. so this hopes and prays that the TSC wrackage happens in the
first 10 minutes after boot.
Given the previous patch, the watchdog wouldn't be running at all on
modern machines, so why wreck it for the old machines where it's
actually needed?
next prev parent reply other threads:[~2021-03-02 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 2:54 Feng Tang
2021-03-02 9:16 ` Peter Zijlstra [this message]
2021-03-02 12:06 ` Feng Tang
2021-03-03 15:50 ` Thomas Gleixner
2021-03-04 7:43 ` Feng Tang
2021-03-04 14:15 ` Thomas Gleixner
2021-03-05 2:30 ` Feng Tang
2021-03-25 8:34 ` Feng Tang
2021-03-25 11:40 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YD4CdQqX5Lea1rB5@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=andi.kleen@intel.com \
--cc=feng.tang@intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qais.yousef@arm.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®