From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7F1EC433E0 for ; Wed, 3 Mar 2021 12:55:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 87650601FF for ; Wed, 3 Mar 2021 12:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442074AbhCCL6R (ORCPT ); Wed, 3 Mar 2021 06:58:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:41698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232388AbhCCFkz (ORCPT ); Wed, 3 Mar 2021 00:40:55 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 81C0364EA4; Wed, 3 Mar 2021 05:40:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614750010; bh=nf6BgVXIglExdD5I5xeTnP34a41bqPXPoX9F4q//kRU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XpvEbW4eQ0LNJQbFhRNGv8wV4Ddg3kcRxzZjkaiiNK4aSWuynE3/uZ9yz0rZO04ww 3tj23MZAksENaVJai6vEZHYA8m9u32LJYGpVwU2RFayBHC6Y6pc72eZgxcKq4FHvVX /+wiWEmIXMZV1sBdkIWzFQ/xLkG7JTJftv42sd/HLlEJ7t3EuhpGk9LpI5YThw9ya6 yJCBccbFAsf/LJiY8g70tx2484vVXPqIEQffGcLea5mvysjLeVmMHPp3iN7su5d6M1 6f86psUdwq78w5ijHKigbWXvYJp0EcaHH5Xu5iXswyZIhkFMqlahTITw06Q9w/C6RW j+lQcuClWkSxw== Date: Wed, 3 Mar 2021 11:10:06 +0530 From: Vinod Koul To: Daniel Lezcano Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Etienne Carriere , Chunfeng Yun , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" Subject: Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Message-ID: References: <20210224144222.23762-1-daniel.lezcano@linaro.org> <20210224144222.23762-9-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-03-21, 18:03, Daniel Lezcano wrote: > On 02/03/2021 17:32, Vinod Koul wrote: > > On 24-02-21, 15:42, Daniel Lezcano wrote: > >> HZ unit conversion macros are available in units.h, use them and > >> remove the duplicate definition. > >> > >> Signed-off-by: Daniel Lezcano > >> --- > >> drivers/phy/st/phy-stm32-usbphyc.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > >> index a54317e96c41..02dd12bb4692 100644 > >> --- a/drivers/phy/st/phy-stm32-usbphyc.c > >> +++ b/drivers/phy/st/phy-stm32-usbphyc.c > >> @@ -14,6 +14,7 @@ > >> #include > >> #include > >> #include > >> +#include > >> > >> #define STM32_USBPHYC_PLL 0x0 > >> #define STM32_USBPHYC_MISC 0x8 > >> @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { > >> #define PLL_FVCO_MHZ 2880 > >> #define PLL_INFF_MIN_RATE_HZ 19200000 > >> #define PLL_INFF_MAX_RATE_HZ 38400000 > >> -#define HZ_PER_MHZ 1000000L > > > > I dont see this in units.h, can you send this once it is merged upstream > > Actually, it is the first patch of the series. > > I asked Rafael if he can merge the entire series. Pls cc folks on cover at least so that they are aware. Thanks -- ~Vinod