From: Greg KH <gregkh@linuxfoundation.org>
To: Julian Braha <julianbraha@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: fix kconfig dependency on CRYPTO
Date: Sat, 20 Feb 2021 08:02:23 +0100 [thread overview]
Message-ID: <YDCz/6gQgp07NGw2@kroah.com> (raw)
In-Reply-To: <8483722.hVsnvgcxvV@ubuntu-mate-laptop>
On Fri, Feb 19, 2021 at 06:14:57PM -0500, Julian Braha wrote:
> commit 1a3f343027d7f5a6475a019aa20be89795b8c8e0
> Author: Julian Braha <julianbraha@gmail.com>
> Date: Fri Feb 19 17:02:24 2021 -0500
>
> staging: rtl8192e: fix kconfig dependency on CRYPTO
>
> When RTLLIB_CRYPTO_TKIP is enabled and CRYPTO is disabled,
> Kbuild gives the following warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_MICHAEL_MIC
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
>
> WARNING: unmet direct dependencies detected for CRYPTO_LIB_ARC4
> Depends on [n]: CRYPTO [=n]
> Selected by [m]:
> - RTLLIB_CRYPTO_TKIP [=m] && STAGING [=y] && RTLLIB [=m]
> - RTLLIB_CRYPTO_WEP [=m] && STAGING [=y] && RTLLIB [=m]
>
> This is because RTLLIB_CRYPTO_TKIP selects CRYPTO_MICHAEL_MIC and CRYPTO_LIB_ARC4,
> without depending on or selecting CRYPTO, despite those config options
> being subordinate to CRYPTO.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
>
> diff --git a/drivers/staging/rtl8192e/Kconfig b/drivers/staging/rtl8192e/Kconfig
> index 03fcc23516fd..6e7d84ac06f5 100644
> --- a/drivers/staging/rtl8192e/Kconfig
> +++ b/drivers/staging/rtl8192e/Kconfig
> @@ -26,6 +26,7 @@ config RTLLIB_CRYPTO_CCMP
> config RTLLIB_CRYPTO_TKIP
> tristate "Support for rtllib TKIP crypto"
> depends on RTLLIB
> + select CRYPTO
> select CRYPTO_LIB_ARC4
> select CRYPTO_MICHAEL_MIC
> default y
Odd indentation :(
next prev parent reply other threads:[~2021-02-20 7:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:14 Julian Braha
2021-02-20 7:02 ` Greg KH [this message]
2021-02-20 17:22 ` [PATCH v1] " Julian Braha
2021-02-21 13:07 ` Greg KH
2021-02-22 18:06 [PATCH] staging: " Julian Braha
2021-02-22 21:13 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDCz/6gQgp07NGw2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®